Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from update/networkservicemesh/sdk #187

Merged
merged 1 commit into from
May 11, 2021

Conversation

nsmbot
Copy link
Contributor

@nsmbot nsmbot commented May 11, 2021

commit 0e7a466 Author: NSMBot nsmbot@networkservicmesh.io Date: Tue May 11 14:23:28 2021 +0000 Update go.mod and go.sum to latest version from networkservicemesh/sdk@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit 93d252947219d952fd428e98e86e63ea17550579 Author: Uzlov Danil 36223296+d-uzlov@users.noreply.github.com Date: Tue May 11 21:22:51 2021 +0700 Add onidle chain element (#908) Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go add endpointtimeout chain element Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go fix TestEndpointTimeout_ContextCancel instability Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go make endpointTimeoutServer track connections, fix concurrency issues Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go rename package endpointtimeout to idlenotifier Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go fix formatting Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go add HoldingActiveRequest test, clean code Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go fix race in *endpointTimeoutServer) Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go add TestIdleNotifier_FailedRequest Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go fix missing error check Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go make idlenotifier.notify action argument mandatory Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go rename package idlenotifier to onidle Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go fix TestIdleNotifier_ContextCancel instability Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go clean code Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go fix race in onIdleServer Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go fix timer leak Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go use require.Eventually + goleak.Find instead of time.Sleep in TestIdleNotifier_ContextCancel Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go remove excessive removeConnection call Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go use simple map instead of sync.Map in onIdleServer Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go adjuct comments Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go refactor timer handling Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go add TestIdleNotifier_RequestAfterExpire test Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go remove unneeded check from TestIdleNotifier_ContextCancel Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go fix non-american "cancelled" spelling error Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go add extra check for context error Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go increase check timeout from 50ms to 100ms Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go extract notify callback to be not under the mutex Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go apply suggestions from code review Signed-off-by: Danil Uzlov DanilUzlov@yandex.ru Signed-off-by: NSMBot nsmbot@networkservicmesh.io

…k@main networkservicemesh/sdk#

networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/

networkservicemesh/sdk commit message:
commit 93d252947219d952fd428e98e86e63ea17550579
Author: Uzlov Danil <36223296+d-uzlov@users.noreply.github.com>
Date:   Tue May 11 21:22:51 2021 +0700

    Add onidle chain element (#908)

    * add endpointtimeout chain element

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * fix TestEndpointTimeout_ContextCancel instability

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * make endpointTimeoutServer track connections, fix concurrency issues

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * rename package endpointtimeout to idlenotifier

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * fix formatting

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * add HoldingActiveRequest test, clean code

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * fix race in *endpointTimeoutServer)

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * add TestIdleNotifier_FailedRequest

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * fix missing error check

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * make idlenotifier.notify action argument mandatory

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * rename package idlenotifier to onidle

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * fix TestIdleNotifier_ContextCancel instability

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * clean code

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * fix race in onIdleServer

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * fix timer leak

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * use require.Eventually + goleak.Find instead of time.Sleep in TestIdleNotifier_ContextCancel

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * remove excessive removeConnection call

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * use simple map instead of sync.Map in onIdleServer

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * adjuct comments

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * refactor timer handling

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * add TestIdleNotifier_RequestAfterExpire test

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * remove unneeded check from TestIdleNotifier_ContextCancel

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * fix non-american "cancelled" spelling error

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * add extra check for context error

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * increase check timeout from 50ms to 100ms

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * extract notify callback to be not under the mutex

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

    * apply suggestions from code review

    Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@github-actions github-actions bot merged commit 900b4a8 into main May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant