implement icmp responder #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
edwarnicke
reviewed
Sep 7, 2020
| ctx := signalctx.WithSignals(context.Background()) | ||
| ctx, cancel := context.WithCancel(ctx) | ||
|
|
||
| // setup logging |
There was a problem hiding this comment.
You may wish to consider this style of section comment:
https://github.com/networkservicemesh/cmd-nsc/blob/master/main.go#L75
edwarnicke
reviewed
Sep 7, 2020
| nsmTarget = config.ConnectTo.String() | ||
| } | ||
|
|
||
| cc, err := grpc.DialContext(ctx, |
There was a problem hiding this comment.
You may want to call out here that you are registering the networkservice in this section.
Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
Comment on lines
+157
to
+162
| nse, err := registry.NewNetworkServiceEndpointRegistryClient(cc).Register(context.Background(), ®istry.NetworkServiceEndpoint{ | ||
| Name: config.EndpointName, | ||
| NetworkServiceNames: []string{config.Name}, | ||
| ExpirationTime: ×tamp.Timestamp{Seconds: time.Now().Add(time.Hour * 24).Unix()}, | ||
| }) | ||
| logrus.Infof("nse: %+v", nse) |
There was a problem hiding this comment.
I think we also need to register network service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1