Update from update/networkservicemesh/sdk #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k@main PR link: networkservicemesh/sdk#1650 Commit: 3016313 Author: Nikita Skrynnik Date: 2024-08-08 21:03:55 +1100 Message: - Add a timeout for Closes in begin.Server (#1650) * fix corner cases of the begin chain element Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * disable Test_RestartDuringRefresh Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add fresh context Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add extended context Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add refreshed close context everywhere in begin Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix some unit tests Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * unskip some tests Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * debug Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix race condition Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add unit tests Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix race conditiong Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Aug 8, 2024
…d-nse-remote-vlan@main PR link: networkservicemesh/cmd-nse-remote-vlan#235 Commit: 9c325a4 Author: Network Service Mesh Bot Date: 2024-08-08 05:07:20 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#235) PR link: networkservicemesh/sdk#1650 Commit: 3016313 Author: Nikita Skrynnik Date: 2024-08-08 21:03:55 +1100 Message: - Add a timeout for Closes in begin.Server (#1650) * fix corner cases of the begin chain element * disable Test_RestartDuringRefresh * add fresh context * add extended context * add refreshed close context everywhere in begin * fix some unit tests * unskip some tests * fix golang linter issues * debug * cleanup * fix race condition * add unit tests * fix go linter issues * fix race conditiong * apply review comments --------- Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go.mod and go.sum to latest version from networkservicemesh/sdk@main PR link: networkservicemesh/sdk#1650
Commit: 7bcaff3
Author: NSMBot
Date: Thu Aug 8 10:04:55 2024 +0000