Add vfio-server #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 10, 2020 12:58
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
vfio-server
branch
from
c89d053
to
c4175c3
Compare
added 2 commits
December 10, 2020 14:49
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
vfio-server
branch
from
d95c39e
to
0137746
Compare
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
vfio-server
branch
from
5925cdb
to
a01453e
Compare
| @@ -20,4 +23,5 @@ CMD dlv -l :40000 --headless=true --api-version=2 test -test.v ./... | |||
|
|
|||
| FROM alpine as runtime | |||
| COPY --from=build /bin/app /bin/app | |||
| COPY --from=build /bin/dlv /bin/dlv | |||
There was a problem hiding this comment.
Note: you could use target debug.
Suggested change
| COPY --from=build /bin/dlv /bin/dlv |
There was a problem hiding this comment.
Yes, but there is an additional option to start debugging ourselves with passed env variable:
Lines 77 to 79 in a01453e
There was a problem hiding this comment.
I'm not sure that we need dlv in runtiume.
| "github.com/networkservicemesh/cmd-nse-vfio/internal/config" | ||
| ) | ||
|
|
||
| type mapServer struct { |
There was a problem hiding this comment.
Why it is not part of sdk-sriov?
haiodo
reviewed
Dec 11, 2020
| // Name@Domain: { addr: MACAddr; vlan: VLANTag; labels: Labels; } | ||
| // MACAddr = xx:xx:xx:xx:xx:xx | ||
| // Labels = label_1=value_1&label_2=value_2 | ||
| func (s *ServiceConfig) UnmarshalBinary(bytes []byte) (err error) { |
haiodo
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vfio-servernse providesnetwork service -> { MAC address, VLAN tag }mapping.Configuration
Name@Domain: { addr: MACAddr; vlan: VLANTag; labels: Labels; }
MACAddr = xx:xx:xx:xx:xx:xx
Labels = label_1=value_1&label_2=value_2
- Name - a Network Service name
- Domain - a Network Service domain (don't confuse it with interdomain domains)
- MACAddr - a MAC address for the Network Service
- VLANTag - a VLAN tag for the Network Service
- labelN=valueN - pairs of labels supported by the Network Service