Update go to 1.23 #717
Merged
Update go to 1.23 #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
Ex4amp1e
force-pushed
the
update-go-1.23
branch
from
886a842 to
d0a9cdb
Compare
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
Comment on lines
+148
to
+151
| exclude-rules: | ||
| - path: main.go | ||
| linters: | ||
| - revive |
There was a problem hiding this comment.
Fixed by adding specific error text
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
denis-tingaikin
approved these changes
Nov 21, 2024
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Nov 21, 2024
…d-nsmgr@main PR link: networkservicemesh/cmd-nsmgr#717 Commit: 160bca7 Author: Vladislav Byrgazov Date: 2024-11-21 05:19:02 +0500 Message: - Update go to 1.23 (#717) * Update go to 1.23 Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Update linter config Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> * Fix revive linter exclude Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Nov 21, 2024
…d-nsmgr@main (#12529) PR link: networkservicemesh/cmd-nsmgr#717 Commit: 160bca7 Author: Vladislav Byrgazov Date: 2024-11-21 05:19:02 +0500 Message: - Update go to 1.23 (#717) * Update go to 1.23 * Update linter config * Fix revive linter exclude --------- Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: networkservicemesh/deployments-k8s#12294