Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker tests for cmd-registry-memory is outdated #172

Merged
merged 3 commits into from
Jan 12, 2021
Merged

fix: docker tests for cmd-registry-memory is outdated #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1842715
Sync files with networkservicemesh/cmd-template
Jan 11, 2021
2468037
fix failing tests
Jan 11, 2021
4561224
fix linter issues
denis-tingaikin Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,8 @@ jobs:
update-deployments-k8s:
name: Update deployments-k8s
runs-on: ubuntu-latest
needs:
- pushImage
if: github.repository != 'networkservicemesh/cmd-template' && github.actor == 'nsmbot' && github.base_ref == 'master' && github.event_name == 'pull_request'
steps:
- name: Checkout ${{ github.repository }}
Expand Down
8 changes: 5 additions & 3 deletions main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2020 Doc.ai and/or its affiliates.
// Copyright (c) 2020-2021 Doc.ai and/or its affiliates.
//
// SPDX-License-Identifier: Apache-2.0
//
Expand Down Expand Up @@ -203,7 +203,9 @@ func (t *RegistryTestSuite) TestNetworkServiceEndpointRegistration() {

t.Nil(err)
t.NotEmpty(result.Name)
stream, err := client.Find(context.Background(), &registry.NetworkServiceEndpointQuery{NetworkServiceEndpoint: result})
stream, err := client.Find(context.Background(), &registry.NetworkServiceEndpointQuery{NetworkServiceEndpoint: &registry.NetworkServiceEndpoint{
Name: result.Name,
}})
t.Nil(err)
list := registry.ReadNetworkServiceEndpointList(stream)
t.Len(list, 1)
Expand Down Expand Up @@ -245,7 +247,7 @@ func (t *RegistryTestSuite) TestNetworkServiceEndpointRegistrationExpiration() {
t.Nil(err)
list = registry.ReadNetworkServiceEndpointList(stream)
return len(list) == 0
}, time.Second*5, time.Millisecond*100)
}, time.Until(result.GetExpirationTime().AsTime())+time.Second*5, time.Millisecond*100)
}

func (t *RegistryTestSuite) TestNetworkServiceEndpointClientRefreshingTime() {
Expand Down