replace - with _ in envvar #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
| @@ -76,10 +76,10 @@ func main() { | |||
|
|
|||
| // Get config from environment | |||
| config := &Config{} | |||
| if err := envconfig.Usage("registry-memory", config); err != nil { | |||
There was a problem hiding this comment.
Interesting.. it is working with k8s https://github.com/networkservicemesh/integration-k8s-kind/blob/master/deployments/registry-memory.yaml#L22, but looks like it is not working in external cases :)
denis-tingaikin
approved these changes
Sep 6, 2020
nsmbot
pushed a commit
that referenced
this pull request
Jun 2, 2021
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/2888f9b1a2e11107cf150ba022d56b8741c06436 commit 2888f9b1a2e11107cf150ba022d56b8741c06436 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jun 3 01:19:57 2021 +0700 update docker-push-ghcr pattern (#76) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valid envvars are
A-Z,0-9and_Replacing
-with_.