Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsm-spire image #773

Closed
rpiceage opened this issue Apr 14, 2021 · 10 comments
Closed

nsm-spire image #773

rpiceage opened this issue Apr 14, 2021 · 10 comments
Labels
question Further information is requested

Comments

@rpiceage
Copy link

In NSM old gen there was an nsm-spire sidecar image for handling spire configuration. Is there any plan to create it for the next gen also? Or is there some recommended way how to handle spire workload registration based on config files, without entry create commands?

@denis-tingaikin denis-tingaikin added the question Further information is requested label Apr 14, 2021
@denis-tingaikin
Copy link
Member

denis-tingaikin commented Apr 14, 2021

Currently, we do not plan to add automatization for spire registration. I feel this may be scheduled in the future.

@edwarnicke , @fkautz Could you share thoughts about this?

@edwarnicke
Copy link
Member

@rpiceage Could you provide more specific detail around your needs in this regard. It may make more sense for us to contribute upstream to spire.

@rpiceage
Copy link
Author

@edwarnicke The aim is to be able to ship the config together with the other stuff, so we want to avoid additional config steps through the spire server CLI after deployment. The nsm-spire sidecar is exactly doing this together with the config file called registration.json which contains the necessary entries for spire.
In fact yesterday I managed to reuse that old image, so it works now temporarily for us. So my question is whether there will be some equivalent in your newer repos, or will it be maintained so that we can use it long term?

@edwarnicke
Copy link
Member

@rpiceage Got it. So it sounds like something that would let you ship a CRD for config (ie, just another part of the yaml) would meet your needs. Its more a declarative vs imperative thing than anything.

I've kicked off a conversation on the spire slack here. Would be good to get more voices there :)

@edwarnicke
Copy link
Member

@rpiceage Question: if the existing spire-server containers could have identities updated via ConfigMaps updating config files for that container... would it get you where you need to go?

@rpiceage
Copy link
Author

@edwarnicke As I understand, the config file for the spire server could not contain the entries needed to be injected as our configuration.
On the other hand the CRD solution would be OK. Also I will have a go at the spire k8s-workload-registrar, maybe it can solve the problem.

@rpiceage
Copy link
Author

@edwarnicke It seems that the k8s-workload-registrar image provided by Spire works for us, so there is no need for the former nsm-spire functionality at the moment.
Thanks for the support, I think we can close this issue.

@edwarnicke
Copy link
Member

@rpiceage Excellent news!

@denis-tingaikin
Copy link
Member

it sounds like we can simplify a bit our examples if we'll use k8s-workload-registrar. @edwarnicke Do we need to update our examples and use k8s-workload-registrar?

@edwarnicke
Copy link
Member

@denis-tingaikin Lets look into it :)

nsmbot pushed a commit that referenced this issue Aug 15, 2024
…d-nsc-init@main

PR link: networkservicemesh/cmd-nsc-init#773

Commit: 9ab1937
Author: Network Service Mesh Bot
Date: 2024-08-15 15:58:12 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#773)
PR link: networkservicemesh/sdk-sriov#606
Commit: 119f4be
Author: Network Service Mesh Bot
Date: 2024-08-15 15:55:02 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#606)
PR link: networkservicemesh/sdk-kernel#675
Commit: 8fc8a72
Author: Network Service Mesh Bot
Date: 2024-08-15 15:51:37 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#675)
PR link: networkservicemesh/sdk#1658
Commit: eeb0114
Author: Network Service Mesh Bot
Date: 2024-08-15 15:49:07 -0500
Message:
                - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1658)
PR link: networkservicemesh/api#174
Commit: fdbfcd8
Author: Nikita Skrynnik
Date: 2024-08-15 21:15:54 +1100
Message:
                                - Revert changes in strToIPNet func (#174)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this issue Oct 1, 2024
…d-forwarder-sriov@main

PR link: networkservicemesh/cmd-forwarder-sriov#773

Commit: 0c2ec1c
Author: Network Service Mesh Bot
Date: 2024-09-30 20:52:12 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#773)
PR link: networkservicemesh/sdk-k8s#527
Commit: cac9089
Author: Ed Warnicke
Date: 2024-09-30 20:48:37 -0500
Message:
    - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit that referenced this issue Oct 1, 2024
…d-forwarder-sriov@main (#12332)

PR link: networkservicemesh/cmd-forwarder-sriov#773

Commit: 0c2ec1c
Author: Network Service Mesh Bot
Date: 2024-09-30 20:52:12 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#773)
PR link: networkservicemesh/sdk-k8s#527
Commit: cac9089
Author: Ed Warnicke
Date: 2024-09-30 20:48:37 -0500
Message:
    - Merge pull request #527 from networkservicemesh/fix-etcd-ifcase-update

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants