Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from update/networkservicemesh/cmd-nsmgr #739

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

nsmbot
Copy link
Contributor

@nsmbot nsmbot commented Apr 12, 2021

commit 6431d36 Author: NSMBot nsmbot@networkservicmesh.io Date: Mon Apr 12 02:47:17 2021 +0000 Update application version to latest version from networkservicemesh/cmd-nsmgr@master networkservicemesh/cmd-nsmgr#229 networkservicemesh/cmd-nsmgr PR link: networkservicemesh/cmd-nsmgr#229 networkservicemesh/cmd-nsmgr commit message: commit 31dddf1cbc43236e6f507789a4b5db2075dbef29 Author: Network Service Mesh Bot 60070799+nsmbot@users.noreply.github.com Date: Sun Apr 11 21:43:04 2021 -0500 Merge bbd749bbbb1b368f04036a68793a44c9f8805c63 into 36cd58f285b724d1fedb43b1fec3185b205f4709 Signed-off-by: NSMBot nsmbot@networkservicmesh.io

…cmd-nsmgr@master networkservicemesh/cmd-nsmgr#

networkservicemesh/cmd-nsmgr PR link: https://github.com/networkservicemesh/cmd-nsmgr/pull/

networkservicemesh/cmd-nsmgr commit message:
commit 32af5042ec4c4b0ecd09cacf608274f999451276
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Tue Apr 13 18:08:31 2021 +0700

    fix issue related to sync with latest cmd-template (#231)

    * Sync files with networkservicemesh/cmd-template

    This PR syncs files with https://github.com/networkservicemesh/cmd-template

    Revision: https://github.com/networkservicemesh/cmd-template/commits/0ce6ac57e0d81c17b60f2af1a3e2c2264be4bb5c

    commit 0ce6ac57e0d81c17b60f2af1a3e2c2264be4bb5c
    Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
    Date:   Tue Apr 13 02:31:03 2021 +0700

        fix update deps job (#67)

        Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>

    Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

    * fix issue related to sync with latest cmd-template

    Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

    Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot force-pushed the update/networkservicemesh/cmd-nsmgr branch from 6431d36 to c5918a6 Compare April 13, 2021 11:08
@github-actions github-actions bot merged commit da4e695 into main Apr 13, 2021
nsmbot pushed a commit that referenced this pull request Oct 25, 2022
…d-forwarder-vpp@main

PR link: networkservicemesh/cmd-forwarder-vpp#739

Commit: a2c0b6d
Author: Ed Warnicke
Date: 2022-10-25 02:59:01 -0500
Message:
  - Final fix to disable IPv6 RA when NSM_TUNNEL_IP is IPv6 (#739)
VPP, being a router, presumes that any IPv6 enabled interface should,
by default, be sending IPv6 Router Announcements (RAs).

In our case, this is an incorrect behavior.

In the past we had attempted using:

'ip6 nd host-%s ra-cease'

this did not work as expected for two reasons:

1.  It was done before assigning an IPv6 address to the interface.
    Because of this the interface does not yet have IPv6 enabled,
    and therefore the 'ip6 nd host-%s ra-cease' has no effect.
2.  'ip6 nd host-%s ra-cease' only precluded repetition of RAs
    after the interface is up.  Initial RAs are still sent.
    This can be fixed by adding 'ra-suppress'

So in short, we use:
'enable ip6 interface host-%s'
'ip6 nd host-%s ra-cease ra-suppress'

which disables any sending of RAs from the interface prior to it
being 'upped'.

This has been tested using tcpdump. Tcpdump was used in the uncorrected
case to ensure it correctly detects RAs being sent out (it does)
Tcpdump was used to determine that with:

'enable ip6 interface host-%s'
'ip6 nd host-%s ra-cease'

the initial RA is sent, but no subsequent RAs.

The actual fix was tested with tcpdump to ensure that

'enable ip6 interface host-%s'
'ip6 nd host-%s ra-cease ra-suppress'

results in *no* RAs being sent.

Finally, tcpdump was used to ensure that with the code being submitted
was used, not RAs were sent out.

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this pull request Apr 18, 2024
…d-nsc-init@main

PR link: networkservicemesh/cmd-nsc-init#739

Commit: d7cf50e
Author: Network Service Mesh Bot
Date: 2024-04-18 05:08:48 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#739)
PR link: networkservicemesh/sdk-sriov#590
Commit: 53b4eee
Author: Network Service Mesh Bot
Date: 2024-04-18 05:03:45 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#590)
PR link: networkservicemesh/sdk-kernel#659
Commit: 2a4c669
Author: Network Service Mesh Bot
Date: 2024-04-18 04:56:06 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#659)
PR link: networkservicemesh/sdk#1584
Commit: 608b1b5
Author: Lazy Bear
Date: 2024-04-18 13:48:31 +0400
Message:
                - Add dual stack support. (#1584)
* Add dual stack support.
* Support client multi channel subscription.
* Fix unit tests.
* Fix vL3 test.
---------
Signed-off-by: Vitaliy Guschin <vitaliy.guschin@spirent.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this pull request May 18, 2024
…d-forwarder-sriov@main

PR link: networkservicemesh/cmd-forwarder-sriov#739

Commit: 90d6a82
Author: Network Service Mesh Bot
Date: 2024-05-18 13:45:54 -0500
Message:
  - Update from update/networkservicemesh/sdk-sriov (#739)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main
PR link: networkservicemesh/sdk-sriov#595
Commit: 53551c7
Author: Network Service Mesh Bot
Date: 2024-05-18 13:39:18 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#595)
PR link: networkservicemesh/sdk-kernel#664
Commit: 9502001
Author: Network Service Mesh Bot
Date: 2024-05-18 13:35:42 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#664)
PR link: networkservicemesh/sdk#1626
Commit: 7b51d9c
Author: Vladislav Byrgazov
Date: 2024-05-19 02:33:13 +0800
Message:
                - Fix memory leak in metrics chain element (#1626)
* Fix memory leak in metrics chain element
* Fix lint issues
* Added check is opentelemetry enabled and fixed copyrights
* Fix metrics memory leak by storing temp connection data in metadata
* Added copyright
* Address review comments
* Fixed import
---------
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
* Automatically resolving conflicts in go.mod and updating dependency versions to the latest
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
---------
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit that referenced this pull request May 18, 2024
…d-forwarder-sriov@main (#12025)

PR link: networkservicemesh/cmd-forwarder-sriov#739

Commit: 90d6a82
Author: Network Service Mesh Bot
Date: 2024-05-18 13:45:54 -0500
Message:
  - Update from update/networkservicemesh/sdk-sriov (#739)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main
PR link: networkservicemesh/sdk-sriov#595
Commit: 53551c7
Author: Network Service Mesh Bot
Date: 2024-05-18 13:39:18 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#595)
PR link: networkservicemesh/sdk-kernel#664
Commit: 9502001
Author: Network Service Mesh Bot
Date: 2024-05-18 13:35:42 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#664)
PR link: networkservicemesh/sdk#1626
Commit: 7b51d9c
Author: Vladislav Byrgazov
Date: 2024-05-19 02:33:13 +0800
Message:
                - Fix memory leak in metrics chain element (#1626)
* Fix memory leak in metrics chain element
* Fix lint issues
* Added check is opentelemetry enabled and fixed copyrights
* Fix metrics memory leak by storing temp connection data in metadata
* Added copyright
* Address review comments
* Fixed import
---------


* Automatically resolving conflicts in go.mod and updating dependency versions to the latest

---------

Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant