Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature test cases to ovs suite #9779

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Add feature test cases to ovs suite #9779

merged 1 commit into from
Feb 13, 2024

Conversation

ljkiraly
Copy link
Contributor

@ljkiraly ljkiraly commented Sep 5, 2023 •
edited by huly-github-staging bot
Loading

Description

New tests added to ovs suite.

Issue link

Related issue: #9778

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@ljkiraly ljkiraly changed the title Add feature and healing test cases to ovs suite Add feature test cases to ovs suite Oct 18, 2023
denis-tingaikin
denis-tingaikin approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljkiraly Is this PR ready to merge?

@ljkiraly
Copy link
Contributor Author

ljkiraly commented Dec 19, 2023 •
edited
Loading

@denis-tingaikin Not yet. Some of the feature test cases are not working yet with forwarder-ovs. I have to check them, but forgot to put this on draft.

@ljkiraly ljkiraly force-pushed the ovs-heal-feat branch 3 times, most recently from ff88576 to 6f3932e Compare February 6, 2024 12:20
@ljkiraly ljkiraly marked this pull request as draft February 6, 2024 15:30
@ljkiraly
Add feature test cases to ovs suite
f80e313 
Related issue: networkservicemesh#9778

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
@ljkiraly
Copy link
Contributor Author

ljkiraly commented Feb 12, 2024 •
edited
Loading

@denis-tingaikin I think now this is ready to merge.

Links to successful runs of these test cases:
https://github.com/networkservicemesh/integration-k8s-kind/actions/runs/7812007008?pr=876
https://github.com/networkservicemesh/integration-k8s-kind/actions/runs/7842463225

The aim is to have some regression tests running with OVS forwarder also.
There are still failing heal test cases which I did not added to this suite yet. I will add them as soon as I fixed the cmd-forwarder-ovs.
The vl3 examples are not supported by forwarder-ovs.
The nse-composition with forwarder-ovs must be fixed.

@ljkiraly ljkiraly marked this pull request as ready for review February 12, 2024 11:59
@denis-tingaikin
Copy link
Member

@ljkiraly Woot! Looks good to me!

@glazychev-art Could you also have a look?

@denis-tingaikin denis-tingaikin merged commit 9dc2bb5 into networkservicemesh:main Feb 13, 2024
6 checks passed
nsmbot pushed a commit to networkservicemesh/integration-tests that referenced this pull request Feb 13, 2024
Update go.mod and go.sum to latest version from networkservicemesh/de…
dfd79f0 
…ployments-k8s@main

PR link: networkservicemesh/deployments-k8s#9779

Commit: 446d52d
Author: Network Service Mesh Bot
Date: 2024-02-13 09:17:09 -0600
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/de…
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@glazychev-art glazychev-art glazychev-art approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljkiraly @denis-tingaikin @glazychev-art