fix: return last err from processClient #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this patch makes sense. Could you please look at failed job https://github.com/networkservicemesh/fanout/pull/37/checks?check_run_id=3364249178? |
|
Sure can do, but in a short while, not currently at home. Also could we do something like |
It didn't say why it failed just that it reach max attempts. This was used to debug a error in coredns. This is the issue we found out after we noticed that it was working without cache pluigin. coredns/coredns#4735 Signed-off-by: Vanetta <11271952+xonvanetta@users.noreply.github.com>
|
@denis-tingaikin bump |
| if err == nil { | ||
| return &response{client: c, response: msg, start: start, err: err} | ||
| } | ||
| if f.attempts != 0 { | ||
| j++ | ||
| } | ||
| } | ||
| return &response{client: c, response: nil, start: start, err: errors.New("attempt limit has been reached")} | ||
| return &response{client: c, response: nil, start: start, err: errors.Wrapf(err, "attempt limit has been reached, last err")} |
There was a problem hiding this comment.
Inner error message will be also available:
https://play.golang.org/p/xYkR4ZaMf58
Suggested change
| return &response{client: c, response: nil, start: start, err: errors.Wrapf(err, "attempt limit has been reached, last err")} | |
| return &response{client: c, response: nil, start: start, err: errors.Wrapf(err, "attempt limit has been reached")} |
Closed
|
@xonvanetta Merged this to help @Funami580 catch the problem with TLS. Be free to resolve comment in separate PR. Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't say why it failed just that it reach max attempts.
This was used to debug a error in coredns.
This is the issue we found out after we noticed that it was working
without cache pluigin.
coredns/coredns#4735