-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more remote vlan examples (deployments-k8s#4433) #584
Conversation
At last build has failed test.
|
@ljkiraly Could you have a look?☝️ |
Hello @denis-tingaikin, The base of networkstatic/iperf3 has changed. Now the updated PR for deployment_k8s/#4465 is installing the required package into the test container. |
Depending on deployments-k8s#4465 |
See at https://github.com/networkservicemesh/deployments-k8s/blob/main/external-images.yaml |
Hello @denis-tingaikin, I did not received any comment on the above mentioned PR yet. Should I break it down and have separate PR for fixes? Laszlo |
1009771
to
c5343e6
Compare
@denis-tingaikin Yes, of course. Afternoon I rebased to check the integration tests, but for some reason the forwarder-ovs does not started. In my machine run successfully. Now I increased the test timeout to 1 hour and 40 minutes. I will investigate further if the test fails again. |
Still struggle to get the test stable. Now got some errors waiting for forwarders to start: Strange that these can not be reproduced on my environment. |
Hello @denis-tingaikin, |
35e36d9
to
fc15bbf
Compare
1d21842
to
d699126
Compare
This looks promising. I guess you could try to rebase and PR should pass CI. |
bd2972e
to
6df2eef
Compare
@edwarnicke This PR adds vlan remote tests running on ci. I think it can be merged, other ovs/vlan tests can be considered in separate PRs. Thoughts? |
@denis-tingaikin If you and @ljkiraly think its good to go, I'm good with it too! :) |
52b5512
to
86713f4
Compare
ec70776
to
1134358
Compare
Related PR: deployments-k8s/#4465 Added entry point for remote vlan examples Adjusted test timeout Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Added remote vlan examples entry point
Related PR: deployments-k8s/#4465
Signed-off-by: Laszlo Kiraly laszlo.kiraly@est.tech