[sdk#1026] Use postpone.ContextWithValues() #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bolodya1997
force-pushed
the
sdk#1026/close-context
branch
from
d3fcbb0 to
cf6c8c3
Compare
Bolodya1997
requested review from
pperiyasamy,
denis-tingaikin,
glazychev-art and
Mixaster995
Bolodya1997
changed the title
pperiyasamy
reviewed
Aug 24, 2021
| func (c *injectClient) Request(ctx context.Context, request *networkservice.NetworkServiceRequest, | ||
| opts ...grpc.CallOption) (*networkservice.Connection, error) { | ||
| logger := log.FromContext(ctx).WithField("injectClient", "Request") | ||
| func (c *injectClient) Request(ctx context.Context, request *networkservice.NetworkServiceRequest, opts ...grpc.CallOption) (*networkservice.Connection, error) { |
There was a problem hiding this comment.
can you also make this change for inject server ?
There was a problem hiding this comment.
Inject server first make move and after makes Request, so it doesn't need postpone.
Or can you please point what changes do you mean?
There was a problem hiding this comment.
I was talking about this one, but I guess using closeCtx here for ifMoveBack doesn't have any impact here. please just ignore this comment.
There was a problem hiding this comment.
Thank you for the comment, you are totally right - we should use postpone not only for the Close but also for closing own resources.
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
sdk#1026/close-context
branch
from
cf6c8c3 to
b66e5d7
Compare
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
sdk#1026/close-context
branch
from
b66e5d7 to
b721118
Compare
pperiyasamy
approved these changes
Aug 25, 2021
denis-tingaikin
approved these changes
Aug 25, 2021
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Aug 25, 2021
…k-kernel@main PR link: networkservicemesh/sdk-kernel#300 Commit: 26a9371 Author: Denis Tingaikin Date: 2021-08-26 02:24:38 +0300 Message: - Merge pull request #300 from Bolodya1997/sdk#1026/close-context Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Aug 25, 2021
…k-kernel@main PR link: networkservicemesh/sdk-kernel#300 Commit: 26a9371 Author: Denis Tingaikin Date: 2021-08-26 02:24:38 +0300 Message: - Merge pull request #300 from Bolodya1997/sdk#1026/close-context Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
postpone.ContextWithValues()forClose/Unregisterin failedRequest/Registercases.Depends on networkservicemesh/sdk#1035.Issue link
networkservicemesh/sdk#1026
How Has This Been Tested?
Types of changes