Adding stack to errors #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
wazsone
force-pushed
the
feature/adding-errors-stack
branch
from
a1f0e33 to
1f7c3f2
Compare
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
| return netns.Get() | ||
| nsHandle, err := netns.Get() | ||
| if err != nil { | ||
| return -1, errors.Wrap(err, "failed to create net NS handle") |
There was a problem hiding this comment.
NOTE: we are getting netns
There was a problem hiding this comment.
@denis-tingaikin Thank you, done
| @@ -56,7 +63,7 @@ func RunIn(current, target netns.NsHandle, runner func() error) error { | |||
|
|
|||
| curr, err := netns.Get() | |||
| if err != nil { | |||
| return err | |||
| return errors.Wrap(err, "failed to create net NS handle") | |||
There was a problem hiding this comment.
NOTE: we are getting netns
| } | ||
| if err = netlinkHandle.LinkSetHardwareAddr(l, macAddr); err != nil { | ||
| return errors.Wrapf(err, "failed to set MAC address for the VF: %v", macAddr) | ||
| } | ||
| if err = netlinkHandle.LinkSetUp(l); err != nil { | ||
| return errors.WithStack(err) | ||
| return errors.Wrapf(err, "failed to enable link device %s", l.Attrs().Name) |
There was a problem hiding this comment.
failed to setup link for the interface %v
There was a problem hiding this comment.
@denis-tingaikin Thank you, done
| @@ -71,13 +70,13 @@ func setKernelHwAddress(ctx context.Context, conn *networkservice.Connection, is | |||
| return nil | |||
| } | |||
| if err = netlinkHandle.LinkSetDown(l); err != nil { | |||
| return errors.WithStack(err) | |||
| return errors.Wrapf(err, "failed to disable link device %s", l.Attrs().Name) | |||
There was a problem hiding this comment.
failed to set down link for the interface %v
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Feb 18, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#560 Commit: a321f02 Author: Denis Tingaikin Date: 2023-02-18 14:02:34 +0300 Message: - Merge pull request #560 from wazsone/feature/adding-errors-stack Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-l7-proxy
that referenced
this pull request
Feb 18, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#560 Commit: a321f02 Author: Denis Tingaikin Date: 2023-02-18 14:02:34 +0300 Message: - Merge pull request #560 from wazsone/feature/adding-errors-stack Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Feb 18, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#560 Commit: a321f02 Author: Denis Tingaikin Date: 2023-02-18 14:02:34 +0300 Message: - Merge pull request #560 from wazsone/feature/adding-errors-stack Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to networkservicemesh/sdk#705