Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for working with network namespaces #576

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Fix for working with network namespaces #576

merged 1 commit into from
Mar 17, 2023

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Mar 17, 2023 •
edited
Loading

Issue: networkservicemesh/integration-k8s-packet#320

Main changes:

  1. Got rid of redundant nshandle.RunIn(). Much easier to use netlink.NewHandleAt()
  2. Don't up an interface on Close (moveToHostNetNS)
  3. Try to move the vf to the host namespace, if we get an error from moveToContNetNS
  4. Fixed unsafe work with namespaces in FindHostDevice

@glazychev-art
Fix for working with network namespaces
35f8cdd 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art marked this pull request as ready for review March 17, 2023 10:17
@denis-tingaikin denis-tingaikin merged commit 40f70dd into networkservicemesh:main Mar 17, 2023
nsmbot pushed a commit to networkservicemesh/cmd-nse-l7-proxy that referenced this pull request Mar 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2082467 
…k-kernel@main

PR link: networkservicemesh/sdk-kernel#576

Commit: 40f70dd
Author: Denis Tingaikin
Date: 2023-03-17 13:58:01 +0300
Message:
  - Merge pull request #576 from glazychev-art/fix_netns
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Mar 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2d39288 
…k-kernel@main

PR link: networkservicemesh/sdk-kernel#576

Commit: 40f70dd
Author: Denis Tingaikin
Date: 2023-03-17 13:58:01 +0300
Message:
  - Merge pull request #576 from glazychev-art/fix_netns
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-sriov that referenced this pull request Mar 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
44b5db2 
…k-kernel@main

PR link: networkservicemesh/sdk-kernel#576

Commit: 40f70dd
Author: Denis Tingaikin
Date: 2023-03-17 13:58:01 +0300
Message:
  - Merge pull request #576 from glazychev-art/fix_netns
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Mar 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@ljkiraly ljkiraly Awaiting requested review from ljkiraly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin