Move pinggrouprange to connectioncontext #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
pinggrouprange_move
branch
from
a0614ce
to
db26ef8
Compare
denis-tingaikin
approved these changes
Jul 14, 2023
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Jul 14, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#601 Commit: f7a0057 Author: Denis Tingaikin Date: 2023-07-14 13:21:59 +0300 Message: - Merge pull request #601 from glazychev-art/pinggrouprange_move Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-l7-proxy
that referenced
this pull request
Jul 14, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#601 Commit: f7a0057 Author: Denis Tingaikin Date: 2023-07-14 13:21:59 +0300 Message: - Merge pull request #601 from glazychev-art/pinggrouprange_move Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Jul 14, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#601 Commit: f7a0057 Author: Denis Tingaikin Date: 2023-07-14 13:21:59 +0300 Message: - Merge pull request #601 from glazychev-art/pinggrouprange_move Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we assign an IP address to the kernel interface (this is done in the
connectioncontext), we also should set thepinggrouprange. This element is required for unprivileged livelinesschecker