Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining bridge interfaces after forwarder stoped #276

Closed
ljkiraly opened this issue Oct 24, 2023 · 4 comments
Closed

Remaining bridge interfaces after forwarder stoped #276

ljkiraly opened this issue Oct 24, 2023 · 4 comments
Assignees

Comments

@ljkiraly
Copy link
Contributor

Expected Behavior

After forwarder stopped any interface created and no longer used should be deleted

Current Behavior

The following interfaces remains in the host after forwarder stopped (graceful termination) even after NSM system removal (kubernetes namespace delete): ovs-system and nsm-br - the main bridge interface used by NSM.

Failure Information (for bugs)

The NSM's main bridge should be deleted when forwarder-ovs is stopped, but to delete the ovs-system is risky. In the case of host-ovs this might be used by others. When the OVS is running inside forwarder pod in case of pod termination the ovs is stopped forcefully without the chance to delete the system bridge.

Steps to Reproduce

  1. Start the basic NSM system (registry, nsmgr, forwarder-ovs)
  2. Delete the namespace
  3. Check the host for remainder interfaces (ovs-system, nsm-br)
@denis-tingaikin
Copy link
Member

@edwarnicke Don't you mind if we take care of this?

@ljkiraly Would you like to fix this one?

@ljkiraly
Copy link
Contributor Author

@denis-tingaikin During the fix of issue 9778 I noticed these remaining interfaces. I can take this one.

@ljkiraly ljkiraly self-assigned this Oct 24, 2023
@denis-tingaikin
Copy link
Member

@ljkiraly it'd be fantastic!

ljkiraly added a commit to Nordix/sdk-ovs that referenced this issue Nov 10, 2023
Related issue: networkservicemesh#276

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
ljkiraly added a commit to Nordix/sdk-ovs that referenced this issue Nov 10, 2023
Related issue: networkservicemesh#276

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
ljkiraly added a commit to Nordix/cmd-forwarder-ovs that referenced this issue Nov 10, 2023
Related issue: networkservicemesh/sdk-ovs#276
Related PR: networkservicemesh/sdk-ovs#279

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
ljkiraly added a commit to Nordix/cmd-forwarder-ovs that referenced this issue Nov 14, 2023
Related issue: networkservicemesh/sdk-ovs#276
Related PR: networkservicemesh/sdk-ovs#279

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
ljkiraly added a commit to Nordix/cmd-forwarder-ovs that referenced this issue Nov 28, 2023
Related issue: networkservicemesh/sdk-ovs#276

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
ljkiraly added a commit to Nordix/cmd-forwarder-ovs that referenced this issue Nov 28, 2023
Related issue: networkservicemesh/sdk-ovs#276

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
ljkiraly added a commit to Nordix/cmd-forwarder-ovs that referenced this issue Nov 28, 2023
Related issue: networkservicemesh/sdk-ovs#276

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
ljkiraly added a commit to Nordix/cmd-forwarder-ovs that referenced this issue Nov 28, 2023
Related issue: networkservicemesh/sdk-ovs#276

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
@ljkiraly
Copy link
Contributor Author

Fix merged and verified.

bszirtes pushed a commit to Nordix/cmd-forwarder-ovs that referenced this issue Apr 22, 2024
Related issue: networkservicemesh/sdk-ovs#276

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants