Fix release and pr-for-updates workflows #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
.github/workflows/release.yaml
Outdated
| dependent_repositories: | | ||
| ["cmd-forwarder-sriov", | ||
| "cmd-nsc", | ||
| ["sdk-k8s", |
There was a problem hiding this comment.
Please check dependent_repositories list
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
| @@ -18,6 +20,5 @@ package vfio_test | |||
|
|
|||
| const ( | |||
| vfioDevice = "vfio" | |||
| iommuGroup = 1 | |||
There was a problem hiding this comment.
Why was it deleted?
It is used here - https://github.com/networkservicemesh/sdk-sriov/blob/main/pkg/networkservice/common/mechanisms/vfio/client_test.go#L60
There was a problem hiding this comment.
Linter says that it is unused https://github.com/networkservicemesh/sdk-sriov/runs/7129829384?check_suite_focus=true#step:4:27
There was a problem hiding this comment.
Because of this commit - 9d3fdb5
Need to figure out how to avoid this problem.
There was a problem hiding this comment.
I think we can just move this constant to client_test.go file
NikitaSkrynnik
force-pushed
the
fix-reusable-workflows
branch
from
0537b9d to
c69c9c5
Compare
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
fix-reusable-workflows
branch
from
c69c9c5 to
9dd41cd
Compare
denis-tingaikin
approved these changes
Jun 30, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Jul 1, 2022
…k-sriov@main PR link: networkservicemesh/sdk-sriov#430 Commit: def85c9 Author: Denis Tingaikin Date: 2022-07-01 13:17:01 +0300 Message: - Merge pull request #430 from NikitaSkrynnik/fix-reusable-workflows Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc
that referenced
this pull request
Jul 1, 2022
…k-sriov@main PR link: networkservicemesh/sdk-sriov#430 Commit: def85c9 Author: Denis Tingaikin Date: 2022-07-01 13:17:01 +0300 Message: - Merge pull request #430 from NikitaSkrynnik/fix-reusable-workflows Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Jul 1, 2022
…k-sriov@main PR link: networkservicemesh/sdk-sriov#430 Commit: def85c9 Author: Denis Tingaikin Date: 2022-07-01 13:17:01 +0300 Message: - Merge pull request #430 from NikitaSkrynnik/fix-reusable-workflows Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Jul 1, 2022
…k-sriov@main PR link: networkservicemesh/sdk-sriov#430 Commit: def85c9 Author: Denis Tingaikin Date: 2022-07-01 13:17:01 +0300 Message: - Merge pull request #430 from NikitaSkrynnik/fix-reusable-workflows Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
Jul 1, 2022
…k-sriov@main PR link: networkservicemesh/sdk-sriov#430 Commit: def85c9 Author: Denis Tingaikin Date: 2022-07-01 13:17:01 +0300 Message: - Merge pull request #430 from NikitaSkrynnik/fix-reusable-workflows Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Jul 1, 2022
…k-sriov@main PR link: networkservicemesh/sdk-sriov#430 Commit: def85c9 Author: Denis Tingaikin Date: 2022-07-01 13:17:01 +0300 Message: - Merge pull request #430 from NikitaSkrynnik/fix-reusable-workflows Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-ovs
that referenced
this pull request
Jul 1, 2022
…k-sriov@main PR link: networkservicemesh/sdk-sriov#430 Commit: def85c9 Author: Denis Tingaikin Date: 2022-07-01 13:17:01 +0300 Message: - Merge pull request #430 from NikitaSkrynnik/fix-reusable-workflows Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jul 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com