Skip to content

Commit

Permalink
Revert nsmonitor + add additional checks to prevent random connection…
Browse files Browse the repository at this point in the history
… closes (#832)

* Add nsmonitor again + add additional checks to prevent random connection closes

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
  • Loading branch information
NikitaSkrynnik authored May 27, 2024
1 parent 57d31ec commit 206c366
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions pkg/networkservice/chains/forwarder/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ import (
"github.com/networkservicemesh/sdk-vpp/pkg/networkservice/mechanisms/vxlan"
"github.com/networkservicemesh/sdk-vpp/pkg/networkservice/mechanisms/wireguard"
"github.com/networkservicemesh/sdk-vpp/pkg/networkservice/metrics"
"github.com/networkservicemesh/sdk-vpp/pkg/networkservice/nsmonitor"
"github.com/networkservicemesh/sdk-vpp/pkg/networkservice/pinhole"
"github.com/networkservicemesh/sdk-vpp/pkg/networkservice/tag"
"github.com/networkservicemesh/sdk-vpp/pkg/networkservice/up"
Expand Down Expand Up @@ -166,6 +167,7 @@ func NewServer(ctx context.Context, tokenGenerator token.GeneratorFunc, vppConn
afxdppinhole.NewClient(),
pinhole.NewClient(vppConn, pinhole.WithSharedMutex(pinholeMutex)),
recvfd.NewClient(),
nsmonitor.NewClient(ctx),
sendfd.NewClient(),
},
opts.clientAdditionalFunctionality...,
Expand Down
4 changes: 2 additions & 2 deletions pkg/networkservice/nsmonitor/client.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2022 Cisco and/or its affiliates.
// Copyright (c) 2022-2024 Cisco and/or its affiliates.
//
// SPDX-License-Identifier: Apache-2.0
//
Expand Down Expand Up @@ -85,7 +85,7 @@ func (r *netNSMonitorClient) Request(ctx context.Context, request *networkservic
case <-cancelCtx.Done():
return
case _, ok := <-deleteCh:
if ok {
if ok && cancelCtx.Err() == nil {
factory.Close(begin.CancelContext(cancelCtx))
}
return
Expand Down

0 comments on commit 206c366

Please sign in to comment.