Change xconnect to bridge domain in case of remote vlan #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljkiraly
force-pushed
the
vlan-xconn-to-bridge
branch
3 times, most recently
from
8d7be3c
to
134035a
Compare
ljkiraly
force-pushed
the
vlan-xconn-to-bridge
branch
2 times, most recently
from
4b9f347
to
c029a3e
Compare
ljkiraly
force-pushed
the
vlan-xconn-to-bridge
branch
2 times, most recently
from
8747488
to
00dee63
Compare
edwarnicke
reviewed
Nov 15, 2022
| func (v *l2BridgeDomainServer) Request(ctx context.Context, request *networkservice.NetworkServiceRequest) (*networkservice.Connection, error) { | ||
| if request.GetConnection().GetPayload() != payload.Ethernet { | ||
| return next.Server(ctx).Request(ctx, request) | ||
| } |
There was a problem hiding this comment.
How do we tell this case from a non-vlan Ethernet Payload case?
There was a problem hiding this comment.
At the beginning of function addBridgeDomain there is a check if there is a vlan_id stored for the connection context. The function returns immediately if this is missing. The VLAN ID is stored when the sub-interface is created.
There was a problem hiding this comment.
Might be good to make this clearer by putting such a check up at the top of request so its clear to the reader when we do or don't carry out this chain.
ljkiraly
force-pushed
the
vlan-xconn-to-bridge
branch
3 times, most recently
from
1e143db
to
a14419f
Compare
Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
ljkiraly
force-pushed
the
vlan-xconn-to-bridge
branch
from
a14419f
to
1539820
Compare
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-simple-docker
that referenced
this pull request
Nov 16, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#634 Commit: df106db Author: Laszlo Kiraly Date: 2022-11-16 18:54:33 +0100 Message: - Change xconnect to bridge domain in case of remote vlan (#634) Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Nov 16, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#634 Commit: df106db Author: Laszlo Kiraly Date: 2022-11-16 18:54:33 +0100 Message: - Change xconnect to bridge domain in case of remote vlan (#634) Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Nov 16, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#634 Commit: df106db Author: Laszlo Kiraly Date: 2022-11-16 18:54:33 +0100 Message: - Change xconnect to bridge domain in case of remote vlan (#634) Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Nov 16, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#634 Commit: df106db Author: Laszlo Kiraly Date: 2022-11-16 18:54:33 +0100 Message: - Change xconnect to bridge domain in case of remote vlan (#634) Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Nov 16, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#634 Commit: df106db Author: Laszlo Kiraly Date: 2022-11-16 18:54:33 +0100 Message: - Change xconnect to bridge domain in case of remote vlan (#634) Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 16, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-simple-vl3-docker
that referenced
this pull request
Nov 16, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#634 Commit: df106db Author: Laszlo Kiraly Date: 2022-11-16 18:54:33 +0100 Message: - Change xconnect to bridge domain in case of remote vlan (#634) Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Nov 16, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#634 Commit: df106db Author: Laszlo Kiraly Date: 2022-11-16 18:54:33 +0100 Message: - Change xconnect to bridge domain in case of remote vlan (#634) Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Nov 16, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#634 Commit: df106db Author: Laszlo Kiraly Date: 2022-11-16 18:54:33 +0100 Message: - Change xconnect to bridge domain in case of remote vlan (#634) Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laszlo Kiraly laszlo.kiraly@est.tech