Don't delete ipaddress on Close #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
approved these changes
Sep 7, 2022
|
@edwarnicke Merging this. |
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Sep 7, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#635 Commit: 5972592 Author: Artem Glazychev Date: 2022-09-07 17:26:51 +0700 Message: - Don't delete ipaddress on Close (#635) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Sep 7, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#635 Commit: 5972592 Author: Artem Glazychev Date: 2022-09-07 17:26:51 +0700 Message: - Don't delete ipaddress on Close (#635) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Sep 7, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#635 Commit: 5972592 Author: Artem Glazychev Date: 2022-09-07 17:26:51 +0700 Message: - Don't delete ipaddress on Close (#635) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Sep 7, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#635 Commit: 5972592 Author: Artem Glazychev Date: 2022-09-07 17:26:51 +0700 Message: - Don't delete ipaddress on Close (#635) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Sep 7, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#635 Commit: 5972592 Author: Artem Glazychev Date: 2022-09-07 17:26:51 +0700 Message: - Don't delete ipaddress on Close (#635) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-simple-docker
that referenced
this pull request
Sep 7, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#635 Commit: 5972592 Author: Artem Glazychev Date: 2022-09-07 17:26:51 +0700 Message: - Don't delete ipaddress on Close (#635) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Sep 7, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#635 Commit: 5972592 Author: Artem Glazychev Date: 2022-09-07 17:26:51 +0700 Message: - Don't delete ipaddress on Close (#635) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-simple-vl3-docker
that referenced
this pull request
Sep 7, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#635 Commit: 5972592 Author: Artem Glazychev Date: 2022-09-07 17:26:51 +0700 Message: - Don't delete ipaddress on Close (#635) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: networkservicemesh/deployments-k8s#7055
Motivation:
We don't need to remove the address on closing.
In most cases, Close also removes the target interface and the address will be deleted along with it.
Leaving the address allows us to solve the loopback + unnumbered problem where we don't need to remove the address when the connection is closed.
Signed-off-by: Artem Glazychev artem.glazychev@xored.com