-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface names into NSM metrics #789
Merged
denis-tingaikin
merged 6 commits into
networkservicemesh:main
from
NikitaSkrynnik:task/768_add_interface_names
Jan 16, 2024
Merged
Add interface names into NSM metrics #789
denis-tingaikin
merged 6 commits into
networkservicemesh:main
from
NikitaSkrynnik:task/768_add_interface_names
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
…k/768_add_interface_names
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
LGTM |
denis-tingaikin
approved these changes
Jan 16, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Jan 16, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#789 Commit: 4c9782a Author: Nikita Skrynnik Date: 2024-01-16 20:27:01 +1100 Message: - Add interface names into NSM metrics (#789) * Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:768 Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Add interface names into NSM metrics Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change folder names Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-lb-vl3-vpp
that referenced
this pull request
Jan 16, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#789 Commit: 4c9782a Author: Nikita Skrynnik Date: 2024-01-16 20:27:01 +1100 Message: - Add interface names into NSM metrics (#789) * Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:768 Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Add interface names into NSM metrics Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change folder names Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Jan 16, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#789 Commit: 4c9782a Author: Nikita Skrynnik Date: 2024-01-16 20:27:01 +1100 Message: - Add interface names into NSM metrics (#789) * Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:768 Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Add interface names into NSM metrics Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change folder names Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Jan 16, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#789 Commit: 4c9782a Author: Nikita Skrynnik Date: 2024-01-16 20:27:01 +1100 Message: - Add interface names into NSM metrics (#789) * Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:768 Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Add interface names into NSM metrics Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change folder names Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Jan 16, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#789 Commit: 4c9782a Author: Nikita Skrynnik Date: 2024-01-16 20:27:01 +1100 Message: - Add interface names into NSM metrics (#789) * Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:768 Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Add interface names into NSM metrics Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change folder names Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-simple-docker
that referenced
this pull request
Jan 16, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#789 Commit: 4c9782a Author: Nikita Skrynnik Date: 2024-01-16 20:27:01 +1100 Message: - Add interface names into NSM metrics (#789) * Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:768 Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Add interface names into NSM metrics Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change folder names Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Jan 16, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#789 Commit: 4c9782a Author: Nikita Skrynnik Date: 2024-01-16 20:27:01 +1100 Message: - Add interface names into NSM metrics (#789) * Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:768 Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Add interface names into NSM metrics Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change folder names Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-simple-vl3-docker
that referenced
this pull request
Jan 16, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#789 Commit: 4c9782a Author: Nikita Skrynnik Date: 2024-01-16 20:27:01 +1100 Message: - Add interface names into NSM metrics (#789) * Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:768 Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Add interface names into NSM metrics Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change folder names Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Jan 16, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#789 Commit: 4c9782a Author: Nikita Skrynnik Date: 2024-01-16 20:27:01 +1100 Message: - Add interface names into NSM metrics (#789) * Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:768 Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Add interface names into NSM metrics Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change folder names Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#768
Original PR
#771