Handle empty dns answer (#1344)

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
networkservicemesh · Aug 31, 2022 · ed5cc97 · ed5cc97
1 parent dacfc98
commit ed5cc97
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/tools/dnsutils/cache/handler.go b/pkg/tools/dnsutils/cache/handler.go
@@ -85,6 +85,9 @@ func (h *dnsCacheHandler) updateTTL() {
 }
 
 func validateMsg(m *dns.Msg) bool {
+	if len(m.Answer) == 0 {
+		return false
+	}
 	for _, answer := range m.Answer {
 		if answer.Header().Ttl <= 0 {
 			return false

diff --git a/pkg/tools/dnsutils/fanout/handler.go b/pkg/tools/dnsutils/fanout/handler.go
@@ -102,7 +102,7 @@ func (h *fanoutHandler) waitResponse(ctx context.Context, respCh <-chan *dns.Msg
 				}
 				continue
 			}
-			if resp.Rcode == dns.RcodeSuccess {
+			if resp.Rcode == dns.RcodeSuccess && len(resp.Answer) != 0 {
 				return resp
 			}
 			if respCount == 0 {