Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pkg/tools/signalctx and use go 1.16 NotifyContext from the box #759

Closed
denis-tingaikin opened this issue Mar 8, 2021 · 1 comment · Fixed by networkservicemesh/deployments-k8s#933, networkservicemesh/deployments-k8s#939, networkservicemesh/deployments-k8s#940 or #856
Closed

Remove pkg/tools/signalctx and use go 1.16 NotifyContext from the box #759

denis-tingaikin opened this issue Mar 8, 2021 · 1 comment · Fixed by networkservicemesh/deployments-k8s#933, networkservicemesh/deployments-k8s#939, networkservicemesh/deployments-k8s#940 or #856
Assignees
@Mixaster995
Labels
good first issue Good for newcomers

Comments

@denis-tingaikin
Copy link
Member

https://golang.org/pkg/os/signal/#NotifyContext
@edwarnicke
Copy link
Member

Good catch! I like this idea a lot:)

@edwarnicke edwarnicke added the good first issue Good for newcomers label Apr 5, 2021
This was referenced Apr 22, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this issue Apr 22, 2021
Update application version to latest version from networkservicemesh/…
660102d 
…cmd-registry-k8s@main networkservicemesh/cmd-registry-k8s#

networkservicemesh/cmd-registry-k8s PR link: https://github.com/networkservicemesh/cmd-registry-k8s/pull/

networkservicemesh/cmd-registry-k8s commit message:
commit 613441641244e9fd31a509c01abd795c63f15473
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Thu Apr 22 14:53:27 2021 +0700

    Merge pull request #94 from Mixaster995/main

    fix networkservicemesh/sdk#759 - removed signalctx, added NotifyContext

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this issue Apr 22, 2021
Merged
denis-tingaikin added a commit to networkservicemesh/cmd-nsc-init that referenced this issue Apr 22, 2021
@denis-tingaikin
Merge pull request #18 from Mixaster995/main
fde67b7 
fix networkservicemesh/sdk#759 - removed signalctx, added NotifyContext
denis-tingaikin added a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this issue Apr 22, 2021
@denis-tingaikin
Merge pull request #152 from Mixaster995/main
a39c18a 
fix networkservicemesh/sdk#759
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this issue Apr 22, 2021
Update application version to latest version from networkservicemesh/…
8318862 
…cmd-nsc-init@main networkservicemesh/cmd-nsc-init#

networkservicemesh/cmd-nsc-init PR link: https://github.com/networkservicemesh/cmd-nsc-init/pull/

networkservicemesh/cmd-nsc-init commit message:
commit fde67b723ed6486963d0074706bb994f32e9ce4f
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Thu Apr 22 14:55:13 2021 +0700

    Merge pull request #18 from Mixaster995/main

    fix networkservicemesh/sdk#759 - removed signalctx, added NotifyContext

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this issue Apr 22, 2021
Update application version to latest version from networkservicemesh/…
96abb1b 
…cmd-nse-icmp-responder@main networkservicemesh/cmd-nse-icmp-responder#

networkservicemesh/cmd-nse-icmp-responder PR link: https://github.com/networkservicemesh/cmd-nse-icmp-responder/pull/

networkservicemesh/cmd-nse-icmp-responder commit message:
commit a39c18aa56f50865b311b7cfa7d2073350ca4358
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Thu Apr 22 14:55:25 2021 +0700

    Merge pull request #152 from Mixaster995/main

    fix networkservicemesh/sdk#759

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Apr 22, 2021
Merged
Merged
@Mixaster995 Mixaster995 mentioned this issue Apr 22, 2021
Merged
This was referenced Apr 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mixaster995 Mixaster995

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@edwarnicke @Mixaster995 @denis-tingaikin