Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to end DNS integration: Update dnscontext/client and dnscontext/server to latest changes of SDK #825

Closed
denis-tingaikin opened this issue Apr 12, 2021 · 0 comments · Fixed by #866
Closed

End to end DNS integration: Update dnscontext/client and dnscontext/server to latest changes of SDK #825

denis-tingaikin opened this issue Apr 12, 2021 · 0 comments · Fixed by #866
Assignees
@denis-tingaikin
Labels
bug Something isn't working enhancement New feature or request

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Apr 12, 2021 •
edited
Loading

Related to

#815

Motivation

Since the latest changes, existing https://github.com/networkservicemesh/sdk/blob/master/pkg/networkservice/connectioncontext/dnscontext/server.go and https://github.com/networkservicemesh/sdk/blob/master/pkg/networkservice/connectioncontext/dnscontext/client.go are outdated and cannot correctly work in exsist client/endpoint chains.

Solution

  1. Update dnscontext/client to be able to handle multiple connections. I.e. one client instance to few endpoints.
  2. Add dnscontext/client to chains/client
  3. Make sure that dnscontext/client works fine if there no DNS configs.
  4. Update dnscontext/server.
  5. Fix all issues related to tests failing.

Estimation

7h
@denis-tingaikin denis-tingaikin added bug Something isn't working enhancement New feature or request labels Apr 12, 2021
@denis-tingaikin denis-tingaikin self-assigned this Apr 12, 2021
@denis-tingaikin denis-tingaikin mentioned this issue Apr 12, 2021
Closed
This was referenced Apr 12, 2021
Closed
Closed
Closed
@denis-tingaikin denis-tingaikin mentioned this issue Apr 16, 2021
Closed
denis-tingaikin added a commit to denis-tingaikin/sdk that referenced this issue Apr 24, 2021
@denis-tingaikin
fix issues networkservicemesh#825 and networkservicemesh#836
0360ac6 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin added a commit to denis-tingaikin/sdk that referenced this issue Apr 24, 2021
@denis-tingaikin
fix issues networkservicemesh#825 and networkservicemesh#836
040faa8 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
This was referenced Apr 24, 2021
Merged
Merged
edwarnicke pushed a commit that referenced this issue Apr 26, 2021
@denis-tingaikin
feat: End to end DNS integration: Update dnscontext/client and dnscon…
b3c6763 
…text/server to latest changes of SDK (#866)

* fix issues #825 and #836

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* add decoder

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>

* fix test fail on ci

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>

* fix issue with missed coredns dir

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* do not add dnsclient into chains/client

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
Bolodya1997 pushed a commit to Bolodya1997/sdk that referenced this issue Apr 26, 2021
@denis-tingaikin
feat: End to end DNS integration: Update dnscontext/client and dnscon…
b79bd66 
…text/server to latest changes of SDK (networkservicemesh#866)

* fix issues networkservicemesh#825 and networkservicemesh#836

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* add decoder

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>

* fix test fail on ci

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>

* fix issue with missed coredns dir

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* do not add dnsclient into chains/client

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
@denis-tingaikin denis-tingaikin mentioned this issue Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-tingaikin denis-tingaikin

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@denis-tingaikin