Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rework discover: Delete time based wait logic #1128

Merged

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented Oct 31, 2021

Issue link

#1124

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Covered by exsist tests
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin denis-tingaikin marked this pull request as draft October 31, 2021 17:32
@denis-tingaikin denis-tingaikin marked this pull request as ready for review October 31, 2021 18:40
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@edwarnicke edwarnicke merged commit a94a249 into networkservicemesh:main Nov 2, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Nov 2, 2021
…k@main

PR link: networkservicemesh/sdk#1128

Commit: a94a249
Author: Denis Tingaikin
Date: 2021-11-02 22:33:03 +0300
Message:
  -  rework discover chain element (#1128)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 2, 2021
…k@main

PR link: networkservicemesh/sdk#1128

Commit: a94a249
Author: Denis Tingaikin
Date: 2021-11-02 22:33:03 +0300
Message:
  -  rework discover chain element (#1128)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Nov 2, 2021
…k@main

PR link: networkservicemesh/sdk#1128

Commit: a94a249
Author: Denis Tingaikin
Date: 2021-11-02 22:33:03 +0300
Message:
  -  rework discover chain element (#1128)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Nov 2, 2021
…k@main

PR link: networkservicemesh/sdk#1128

Commit: a94a249
Author: Denis Tingaikin
Date: 2021-11-02 22:33:03 +0300
Message:
  -  rework discover chain element (#1128)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Nov 2, 2021
…k@main

PR link: networkservicemesh/sdk#1128

Commit: a94a249
Author: Denis Tingaikin
Date: 2021-11-02 22:33:03 +0300
Message:
  -  rework discover chain element (#1128)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 2, 2021
…k@main

PR link: networkservicemesh/sdk#1128

Commit: a94a249
Author: Denis Tingaikin
Date: 2021-11-02 22:33:03 +0300
Message:
  -  rework discover chain element (#1128)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 2, 2021
…k@main

PR link: networkservicemesh/sdk#1128

Commit: a94a249
Author: Denis Tingaikin
Date: 2021-11-02 22:33:03 +0300
Message:
  -  rework discover chain element (#1128)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 2, 2021
…k@main

PR link: networkservicemesh/sdk#1128

Commit: a94a249
Author: Denis Tingaikin
Date: 2021-11-02 22:33:03 +0300
Message:
  -  rework discover chain element (#1128)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 2, 2021
…k@main

PR link: networkservicemesh/sdk#1128

Commit: a94a249
Author: Denis Tingaikin
Date: 2021-11-02 22:33:03 +0300
Message:
  -  rework discover chain element (#1128)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants