Add discoverServer tests #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvfxx
commented
Feb 19, 2020
| NetworkService: ®istry.NetworkService{ | ||
| Name: "secure-intranet-connectivity", | ||
| Matches: []*registry.Match{ | ||
| { |
There was a problem hiding this comment.
If i move Match with empty source selector to beginning of the Matches array, second test case will fail. Is there any guarantee that Match with empty source selector goes last?
There was a problem hiding this comment.
The matches should be considered in order. So if the match with empty selector comes first, it should match. There is no guarantee that Match with empty source selector goes last.
Signed-off-by: Sergey Semenov <sergey.semenov@xored.com>
Signed-off-by: Sergey Semenov <sergey.semenov@xored.com>
lvfxx
force-pushed
the
discover-tests
branch
from
1963b8b
to
1515fae
Compare
nsmbot
pushed a commit
that referenced
this pull request
Nov 5, 2021
…i@main PR link: networkservicemesh/api#116 Commit: b0e4724 Author: Artem Glazychev Date: 2021-11-05 21:53:09 +0700 Message: - Add initial registration time to NetworkServiceEndpoint (#116) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for /pkg/networkservice/common/discover package