Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qfix] Use cloned nse in retry registry #1207

Merged
merged 1 commit into from
Dec 29, 2021
Merged

[qfix] Use cloned nse in retry registry #1207

merged 1 commit into from
Dec 29, 2021

Conversation

glazychev-art
Copy link
Contributor

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

We should use the cloned element for registry retry, because a previous attempt can change something inside

Issue link

networkservicemesh/integration-k8s-kind#537

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Use cloned nse in retry registry
bcfd22f 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit d21ef35 into networkservicemesh:main Dec 29, 2021
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Dec 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
79120e2 
…k@main

PR link: networkservicemesh/sdk#1207

Commit: d21ef35
Author: Artem Glazychev
Date: 2021-12-29 15:34:57 +0700
Message:
  - Use cloned nse in retry registry (#1207)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Dec 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4d80907 
…k@main

PR link: networkservicemesh/sdk#1207

Commit: d21ef35
Author: Artem Glazychev
Date: 2021-12-29 15:34:57 +0700
Message:
  - Use cloned nse in retry registry (#1207)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Dec 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7b7f647 
…k@main

PR link: networkservicemesh/sdk#1207

Commit: d21ef35
Author: Artem Glazychev
Date: 2021-12-29 15:34:57 +0700
Message:
  - Use cloned nse in retry registry (#1207)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Dec 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
79790f9 
…k@main

PR link: networkservicemesh/sdk#1207

Commit: d21ef35
Author: Artem Glazychev
Date: 2021-12-29 15:34:57 +0700
Message:
  - Use cloned nse in retry registry (#1207)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Dec 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f071d15 
…k@main

PR link: networkservicemesh/sdk#1207

Commit: d21ef35
Author: Artem Glazychev
Date: 2021-12-29 15:34:57 +0700
Message:
  - Use cloned nse in retry registry (#1207)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Dec 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0115e74 
…k@main

PR link: networkservicemesh/sdk#1207

Commit: d21ef35
Author: Artem Glazychev
Date: 2021-12-29 15:34:57 +0700
Message:
  - Use cloned nse in retry registry (#1207)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Dec 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
642235e 
…k@main

PR link: networkservicemesh/sdk#1207

Commit: d21ef35
Author: Artem Glazychev
Date: 2021-12-29 15:34:57 +0700
Message:
  - Use cloned nse in retry registry (#1207)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Dec 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fb206ea 
…k@main

PR link: networkservicemesh/sdk#1207

Commit: d21ef35
Author: Artem Glazychev
Date: 2021-12-29 15:34:57 +0700
Message:
  - Use cloned nse in retry registry (#1207)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Dec 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0a34bb9 
…k@main

PR link: networkservicemesh/sdk#1207

Commit: d21ef35
Author: Artem Glazychev
Date: 2021-12-29 15:34:57 +0700
Message:
  - Use cloned nse in retry registry (#1207)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Dec 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
09edf7f 
…k@main

PR link: networkservicemesh/sdk#1207

Commit: d21ef35
Author: Artem Glazychev
Date: 2021-12-29 15:34:57 +0700
Message:
  - Use cloned nse in retry registry (#1207)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mixaster995 Mixaster995 Mixaster995 approved these changes

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@sol-0 sol-0 sol-0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glazychev-art @Mixaster995 @denis-tingaikin @sol-0