fix: Issue when register endpoints with same name #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix-issue-250-registry-k8s
branch
from
aa3b2c8 to
75e2524
Compare
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Jan 30, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Jan 30, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jan 30, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jan 30, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jan 30, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jan 30, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Jan 30, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jan 30, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jan 30, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jan 30, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 30, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Feb 1, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Feb 1, 2022
…k@main PR link: networkservicemesh/sdk#1221 Commit: 953f555 Author: Denis Tingaikin Date: 2022-01-30 21:47:45 +0300 Message: - apply fixes for networkservicemesh/cmd-registry-k8s#250 (#1221) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Description
Previously we reworked the registry #1213.
This conceptually fixes networkservicemesh/cmd-registry-k8s#250 but during testing it, I found a few missed nits in #1213.
This PR covers case networkservicemesh/cmd-registry-k8s#250 and fixes it.
Issue link
Fixes networkservicemesh/cmd-registry-k8s#250
How Has This Been Tested?
Types of changes