call livenessCheck periodically #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
datapath-heal
branch
from
331cdc7 to
a46d33f
Compare
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
| @@ -32,18 +32,21 @@ import ( | |||
| "github.com/networkservicemesh/sdk/pkg/tools/log" | |||
| ) | |||
|
|
|||
| const attemptAfter = time.Millisecond * 200 | |||
| const ( | |||
| attemptAfter = time.Millisecond * 200 | |||
There was a problem hiding this comment.
attemptAfter is not actually using as we realised with @glazychev-art
Please remove this and all dependent code.
glazychev-art
approved these changes
May 4, 2022
| ) | ||
|
|
||
| // LivenessChecker - function that returns true of conn is 'live' and false otherwise | ||
| type LivenessChecker func(deadlineCtx context.Context, conn *networkservice.Connection) bool |
There was a problem hiding this comment.
Please rename LivenessChecker to LivenessCheck in all places
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
May 4, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
May 4, 2022
…k@main PR link: networkservicemesh/sdk#1271 Commit: 5e4251a Author: Nikita Skrynnik Date: 2022-05-04 20:40:43 +0700 Message: - call livenessCheck periodically (#1271) * call livenessCheck periodically Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix datapath ping interval Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Update tests and misc fixes Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Use backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * change func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * get rid of backoff Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add parameters for livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework eventloop for new func signature Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete attempt after Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename dataPlaneCtx to livenessCheckCtx Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename livenessChecker to livenessCheck Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Co-authored-by: Nikolay Chunosov <n.chunosov@yandex.ru> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 4, 2022
This was referenced Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check data-plane aliveness periodically, not only after a control-plane event happens
Continuation of PR #1259
Issue link
#1187
How Has This Been Tested?
Types of changes