Remove duplicate dns configs in response connection in DNSContextClient #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Jul 7, 2022
denis-tingaikin
requested changes
Jul 7, 2022
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
anastasia-malysheva
approved these changes
Jul 8, 2022
denis-tingaikin
requested changes
Jul 11, 2022
Comment on lines
205
to
220
| func merge(a, b []string) []string { | ||
| result := a | ||
| common := make(map[string]bool, len(a)) | ||
|
|
||
| for _, v := range a { | ||
| common[v] = true | ||
| } | ||
|
|
||
| for _, v := range b { | ||
| if _, ok := common[v]; !ok { | ||
| result = append(result, v) | ||
| } | ||
| } | ||
|
|
||
| return result | ||
| } |
There was a problem hiding this comment.
We are going a bit over-complicated here. Moreover, am not sure about merging dns configs because it could produce a ton of new unexpected states. Thus I think we need to consider about using metadata for server dnscontext.
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Jul 12, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jul 12, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Jul 12, 2022
…k@main PR link: networkservicemesh/sdk#1318 Commit: 65679c0 Author: Nikita Skrynnik Date: 2022-07-12 22:08:37 +1100 Message: - Remove duplicate dns configs in response connection in DNSContextClient (#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
anastasia-malysheva
pushed a commit
to anastasia-malysheva/sdk
that referenced
this pull request
Jul 27, 2022
…nt (networkservicemesh#1318) * remove duplicate dns configs in response Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete metadata + add removeDuplicates before request Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * check intersections + add removeDuplicates test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add dns configs check on dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework dns configs check in dnsContextServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSUsecase Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com
Description
Issue link
How Has This Been Tested?
Types of changes