DNS: dnscontext doesn't restore resolv.conf #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
resolv-conf-restore
branch
from
1d73fd8 to
63178f1
Compare
pkg/networkservice/connectioncontext/dnscontext/resolvconf_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Sep 23, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Sep 23, 2022
…k@main PR link: networkservicemesh/sdk#1342 Commit: 143843a Author: Nikita Skrynnik Date: 2022-09-23 17:38:00 +0700 Message: - DNS: dnscontext doesn't restore resolv.conf (#1342) * new solution for resolv.conf restoring Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * resolve linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use dns library to check that we have commented resolv config Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix Test_DNSContextClient_Usecases test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link
#1339
How Has This Been Tested?
Types of changes