qfix: Dont exclude subnets from routes #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix-excludedprefixes-client
branch
from
9670784 to
a9a6f10
Compare
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix-excludedprefixes-client
branch
from
bbb24d8 to
b91e051
Compare
edwarnicke
reviewed
Oct 12, 2022
| var o, b = route.GetPrefixIPNet().Mask.Size() | ||
| if o != b { | ||
| continue | ||
| } |
There was a problem hiding this comment.
This seems to only compare the mask sizes between routes... I don't quite follow how this precludes us from including a Connection's routes/srcAddr/dstAddr in the exclude_prefixes for Refresh requests.
There was a problem hiding this comment.
as I can see srcAddr/dstAddr is already supported we only without a reason exclude a whole subnet from routes. This patch prevents excluding a subnet from routes.
There was a problem hiding this comment.
That will work for now. But we need to be more specific in in the medium term because the routes from other vWires should be included :)
edwarnicke
approved these changes
Oct 12, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1368 Commit: d4d43ae Author: Denis Tingaikin Date: 2022-10-12 19:11:51 +0300 Message: - qfix: Dont exclude subnets from routes (#1368) * dont exclude subnets from routes Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix linter Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingaikin denis.tingajkin@xored.com
Description
We shouldn't exclude whole subnets on refresh
Issue link
How Has This Been Tested?
Types of changes