Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qfix] Return empty spiffeID if path is empty #1400

Merged
merged 1 commit into from
Dec 19, 2022
Merged

[qfix] Return empty spiffeID if path is empty #1400

merged 1 commit into from
Dec 19, 2022

Conversation

NikitaSkrynnik
Copy link
Contributor

Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com

Description

getSpiffeIDFromPath should return empty spiffeID from empty path. For backward compatibility.

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@NikitaSkrynnik
check empty path in getSpiffeIDFromPath function
22381f4 
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik NikitaSkrynnik marked this pull request as ready for review December 19, 2022 09:24
@denis-tingaikin denis-tingaikin merged commit 554e6ac into networkservicemesh:main Dec 19, 2022
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0f0f6cc 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f8e4e13 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4125877 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
90638af 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0e2474d 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8e2005a 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
605ab53 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ad11082 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0fe9987 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8d169a9 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6f14615 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ec336b4 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 19, 2022
Merged
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Dec 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b5ff387 
…k@main

PR link: networkservicemesh/sdk#1400

Commit: 554e6ac
Author: Nikita Skrynnik
Date: 2022-12-19 20:34:55 +1100
Message:
  - check empty path in getSpiffeIDFromPath function (#1400)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 19, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@NikitaSkrynnik NikitaSkrynnik deleted the empty-spiffeid branch July 13, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikitaSkrynnik @denis-tingaikin