Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix searches dns chain element #1417

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Fix searches dns chain element #1417

merged 1 commit into from
Feb 7, 2023

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Feb 7, 2023 •
edited
Loading

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

From man resolv.conf :

search Search list for host-name lookup.
...
Resolver queries ... will be attempted using each component of the search path in turn until a match is found

It will be much more efficient if we check the success of the dns request one by one, rather than all at once.

Issue link

#1414

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Fix searches dns chain element
1236359 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@51ab81f). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1417   +/-   ##
=======================================
  Coverage        ?   67.75%           
=======================================
  Files           ?      267           
  Lines           ?    11611           
  Branches        ?        0           
=======================================
  Hits            ?     7867           
  Misses          ?     3239           
  Partials        ?      505

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glazychev-art glazychev-art marked this pull request as ready for review February 7, 2023 11:05
@denis-tingaikin denis-tingaikin merged commit c1a6ac4 into networkservicemesh:main Feb 7, 2023
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8ca5205 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ad5c60c 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
92d0c5a 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
148c0ce 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8eb76e7 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
69d879f 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
de3f890 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e7ba6f4 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
766e365 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
996982a 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e588854 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
96bea15 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Feb 7, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
36cab91 
…k@main

PR link: networkservicemesh/sdk#1417

Commit: c1a6ac4
Author: Artem Glazychev
Date: 2023-02-07 21:00:36 +0700
Message:
  - Fix searches dns chain element (#1417)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 7, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@NikitaSkrynnik NikitaSkrynnik Awaiting requested review from NikitaSkrynnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glazychev-art @codecov-commenter @denis-tingaikin