Rework request handling in memory handler #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
=======================================
Coverage ? 70.30%
=======================================
Files ? 242
Lines ? 10999
Branches ? 0
=======================================
Hits ? 7733
Misses ? 2767
Partials ? 499 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
denis-tingaikin
requested changes
Mar 29, 2023
| m := new(dns.Msg) | ||
| _ = rw.WriteMsg(m.SetRcode(msg, dns.RcodeSuccess)) | ||
| } else { | ||
| rwWrapper := &responseWriter{ResponseWriter: rw} |
There was a problem hiding this comment.
- please remove
responseWriter.
fanout should handler the server fail.
- add regression unit test
There was a problem hiding this comment.
responseWriter doesn't check only fanout, but any handler that goes after memory handler. If we remove responseWriter we can get an error, because in some cases nothing will be written to rw.
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Mar 31, 2023
glazychev-art
approved these changes
Mar 31, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Apr 10, 2023
…k@main PR link: networkservicemesh/sdk#1443 Commit: 2502d93 Author: Nikita Skrynnik Date: 2023-04-10 14:27:13 +0700 Message: - Rework request handling in memory handler (#1443) * rework request handling in memory handler Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add test for proper handling of nonexistent records check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Apr 10, 2023
This was referenced Apr 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link
#1425
How Has This Been Tested?
Types of changes