Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nsmgr should keep fowarder while conn is fine #1479

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

denis-tingaikin
Copy link
Member

Description

Issue link

Closes networkservicemesh/deployments-k8s#9063

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@0ba94ea). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1479   +/-   ##
=======================================
  Coverage        ?   70.38%           
=======================================
  Files           ?      248           
  Lines           ?    11196           
  Branches        ?        0           
=======================================
  Hits            ?     7880           
  Misses          ?     2816           
  Partials        ?      500           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin denis-tingaikin marked this pull request as ready for review July 3, 2023 16:22
@denis-tingaikin denis-tingaikin self-assigned this Jul 4, 2023
@glazychev-art glazychev-art merged commit 7ec603e into main Jul 5, 2023
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jul 5, 2023
…k@main

PR link: networkservicemesh/sdk#1479

Commit: 7ec603e
Author: Denis Tingaikin
Date: 2023-07-05 11:34:52 +0300
Message:
  - fix: nsmgr should keep fowarder while conn is fine (#1479)
* fix: nsmgr should keep fowarder while conn is fine

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix critical linter issue

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TestVl3_dns is not stable
3 participants