-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nsmgr should keep fowarder while conn is fine #1479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1479 +/- ##
=======================================
Coverage ? 70.38%
=======================================
Files ? 248
Lines ? 11196
Branches ? 0
=======================================
Hits ? 7880
Misses ? 2816
Partials ? 500 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
NikitaSkrynnik
approved these changes
Jul 4, 2023
glazychev-art
approved these changes
Jul 5, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jul 5, 2023
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jul 5, 2023
…k@main PR link: networkservicemesh/sdk#1479 Commit: 7ec603e Author: Denis Tingaikin Date: 2023-07-05 11:34:52 +0300 Message: - fix: nsmgr should keep fowarder while conn is fine (#1479) * fix: nsmgr should keep fowarder while conn is fine Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix critical linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jul 5, 2023
This was referenced Jul 5, 2023
denis-tingaikin
added a commit
that referenced
this pull request
Jul 6, 2023
This reverts commit 7ec603e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link
Closes networkservicemesh/deployments-k8s#9063
How Has This Been Tested?
Types of changes