monitor: handle initial state transfer #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1483 +/- ##
=======================================
Coverage ? 66.97%
=======================================
Files ? 259
Lines ? 12323
Branches ? 0
=======================================
Hits ? 8253
Misses ? 3553
Partials ? 517 ☔ View full report in Codecov by Sentry. |
glazychev-art
force-pushed
the
monitor_fix
branch
3 times, most recently
from
4849445 to
88565d8
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
monitor_fix
branch
from
88565d8 to
1fe56a2
Compare
denis-tingaikin
approved these changes
Nov 23, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 23, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 23, 2023
…k@main PR link: networkservicemesh/sdk#1483 Commit: d109337 Author: Artem Glazychev Date: 2023-11-23 18:16:33 +0700 Message: - monitor: handle initial state transfer (#1483) * monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 23, 2023
denis-tingaikin
pushed a commit
that referenced
this pull request
Dec 3, 2023
* monitor: handle initial state transfer Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add healing test Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we skip processing
INITIAL_STATE_TRANSFERevents that come when connecting to a MonitorServer.This is wrong, because during the time the Request is passed back to the Client from the Endpoint, the event on the monitor service may arrive before the backward Request. Thus, we can find out the current state only when we connect to the MonitorServer, that is, when we receive
ConnectionEventType_INITIAL_STATE_TRANSFER.Issue link
networkservicemesh/cmd-nse-vl3-vpp#197
networkservicemesh/cmd-forwarder-vpp#664
How Has This Been Tested?
Types of changes