Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor: handle initial state transfer #1483

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Jul 6, 2023

Description

Currently, we skip processing INITIAL_STATE_TRANSFER events that come when connecting to a MonitorServer.

This is wrong, because during the time the Request is passed back to the Client from the Endpoint, the event on the monitor service may arrive before the backward Request. Thus, we can find out the current state only when we connect to the MonitorServer, that is, when we receive ConnectionEventType_INITIAL_STATE_TRANSFER.

Issue link

networkservicemesh/cmd-nse-vl3-vpp#197
networkservicemesh/cmd-forwarder-vpp#664

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@cb5a6d2). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1483   +/-   ##
=======================================
  Coverage        ?   66.97%           
=======================================
  Files           ?      259           
  Lines           ?    12323           
  Branches        ?        0           
=======================================
  Hits            ?     8253           
  Misses          ?     3553           
  Partials        ?      517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glazychev-art glazychev-art marked this pull request as ready for review July 7, 2023 05:02
@glazychev-art glazychev-art marked this pull request as draft July 7, 2023 09:25
@glazychev-art glazychev-art force-pushed the monitor_fix branch 3 times, most recently from 4849445 to 88565d8 Compare July 11, 2023 09:24
@glazychev-art glazychev-art marked this pull request as ready for review July 27, 2023 08:55
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit d109337 into networkservicemesh:main Nov 23, 2023
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 23, 2023
…k@main

PR link: networkservicemesh/sdk#1483

Commit: d109337
Author: Artem Glazychev
Date: 2023-11-23 18:16:33 +0700
Message:
  - monitor: handle initial state transfer (#1483)
* monitor: handle initial state transfer

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add healing test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants