Allow begin to process Unregisters without Registers #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
changed the title
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
=======================================
Coverage ? 66.97%
=======================================
Files ? 259
Lines ? 12322
Branches ? 0
=======================================
Hits ? 8253
Misses ? 3551
Partials ? 518 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
glazychev-art
approved these changes
Nov 8, 2023
denis-tingaikin
approved these changes
Nov 8, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 8, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 8, 2023
…k@main PR link: networkservicemesh/sdk#1542 Commit: 20150d6 Author: Nikita Skrynnik Date: 2023-11-08 16:52:52 +0700 Message: - Allow begin to process Unregisters without Registers (#1542) * Allow begin process Unregisters without Registers Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete one test + fix go leaks Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test using mutexes Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more unit tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix some tests + fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test StressTest for begin server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * delete unneseccary test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix dial chain element to fix test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor fix Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * test again Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * disable one test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add some logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more logs Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * reduce count of events to 10 Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * skip fifo test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply some review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments related to dial Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow begin process Unregisters events without Register events. Also added several benchmark tests and test for checking FIFO sequence of Register and Unregister events in begin.
Issue link
networkservicemesh/sdk-k8s#456
#1515
How Has This Been Tested?
Types of changes