Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task:1537 Test_DNSUsecase is unstable #1556

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Task:1537 Test_DNSUsecase is unstable #1556

merged 1 commit into from
Nov 28, 2023

Conversation

dualBreath
Copy link
Contributor

Description

Unstable test

Issue link

#1537

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

Task:1537 Test_DNSUsecase is unstable
f073556 
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
@dualBreath
Copy link
Contributor Author

Tested with several successful runs:
Screenshot 2023-11-13 at 15 59 23

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c7c00eb). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1556   +/-   ##
=======================================
  Coverage        ?   66.92%           
=======================================
  Files           ?      259           
  Lines           ?    12327           
  Branches        ?        0           
=======================================
  Hits            ?     8250           
  Misses          ?     3558           
  Partials        ?      519

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dualBreath
Copy link
Contributor Author

The CI test failure does not appear to be related to the current test:
Screenshot 2023-11-13 at 16 07 23

@dualBreath
Copy link
Contributor Author

@denis-tingaikin @NikitaSkrynnik @glazychev-art @d-uzlov @VitalyGushin please take a look

@denis-tingaikin denis-tingaikin merged commit c1f9028 into networkservicemesh:main Nov 28, 2023
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
712c77f 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
22e4d91 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
afbf0a3 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
94544e9 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fa866a4 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7c2e057 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d610449 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3cdc608 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
22c365b 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d2a94d3 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d8a2cfd 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
78986e8 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3b57594 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 28, 2023
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Nov 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e4f679f 
…k@main

PR link: networkservicemesh/sdk#1556

Commit: c1f9028
Author: Alexander Peretyatko
Date: 2023-11-28 19:06:26 +0700
Message:
  - Task:1537 Test_DNSUsecase is unstable (#1556)
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 28, 2023
Merged
Merged
Merged
Merged
This was referenced Nov 28, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikitaSkrynnik NikitaSkrynnik NikitaSkrynnik approved these changes

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@d-uzlov d-uzlov d-uzlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dualBreath @d-uzlov @denis-tingaikin @NikitaSkrynnik