Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor nanoid package #1608

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Refactor nanoid package #1608

merged 1 commit into from
Apr 5, 2024

Conversation

denis-tingaikin
Copy link
Member

Description

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
refactor nanoid package
7a5d831 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@77fc153). Click here to learn what that means.

Files Patch % Lines
pkg/tools/nanoid/utils.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1608   +/-   ##
=======================================
  Coverage        ?   67.37%           
=======================================
  Files           ?      264           
  Lines           ?    12489           
  Branches        ?        0           
=======================================
  Hits            ?     8415           
  Misses          ?     3546           
  Partials        ?      528

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glazychev-art glazychev-art merged commit edee168 into main Apr 5, 2024
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2896a06 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b55ac77 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fe1cd9a 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2fa6e5f 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c98f742 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
405737a 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-dashboard-backend that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1ab99dc 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f3cf6e2 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
46614ca 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a73eb5c 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
deee91d 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
df0c4d1 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
dbef0e0 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
36987a3 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Apr 5, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
66a3c95 
…k@main

PR link: networkservicemesh/sdk#1608

Commit: edee168
Author: Denis Tingaikin
Date: 2024-04-05 13:31:06 +0300
Message:
  - refactor nanoid package (#1608)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Apr 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikitaSkrynnik NikitaSkrynnik NikitaSkrynnik approved these changes

@glazychev-art glazychev-art glazychev-art approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-tingaikin @glazychev-art @NikitaSkrynnik