fix: AddressToURL should not return local host in case of IP.IsUnspecified #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com>
haiodo
approved these changes
Nov 16, 2020
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 16, 2020
…k@master networkservicemesh/sdk#588 networkservicemesh/sdk PR link: networkservicemesh/sdk#588 networkservicemesh/sdk commit message: commit a04f342c6d6f9cb5aed6f598e9e57d60b1155cc8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Nov 16 20:54:09 2020 +0700 fix: AddressToURL should not return local host in case of IP.IsUnspecified (#588) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Nov 16, 2020
…k@master networkservicemesh/sdk#588 networkservicemesh/sdk PR link: networkservicemesh/sdk#588 networkservicemesh/sdk commit message: commit a04f342c6d6f9cb5aed6f598e9e57d60b1155cc8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Nov 16 20:54:09 2020 +0700 fix: AddressToURL should not return local host in case of IP.IsUnspecified (#588) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 16, 2020
…k@master networkservicemesh/sdk#588 networkservicemesh/sdk PR link: networkservicemesh/sdk#588 networkservicemesh/sdk commit message: commit a04f342c6d6f9cb5aed6f598e9e57d60b1155cc8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Nov 16 20:54:09 2020 +0700 fix: AddressToURL should not return local host in case of IP.IsUnspecified (#588) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 16, 2020
…k@master networkservicemesh/sdk#588 networkservicemesh/sdk PR link: networkservicemesh/sdk#588 networkservicemesh/sdk commit message: commit a04f342c6d6f9cb5aed6f598e9e57d60b1155cc8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Nov 16 20:54:09 2020 +0700 fix: AddressToURL should not return local host in case of IP.IsUnspecified (#588) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 16, 2020
…k@master networkservicemesh/sdk#588 networkservicemesh/sdk PR link: networkservicemesh/sdk#588 networkservicemesh/sdk commit message: commit a04f342c6d6f9cb5aed6f598e9e57d60b1155cc8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Nov 16 20:54:09 2020 +0700 fix: AddressToURL should not return local host in case of IP.IsUnspecified (#588) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Nov 16, 2020
…k@master networkservicemesh/sdk#588 networkservicemesh/sdk PR link: networkservicemesh/sdk#588 networkservicemesh/sdk commit message: commit a04f342c6d6f9cb5aed6f598e9e57d60b1155cc8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Nov 16 20:54:09 2020 +0700 fix: AddressToURL should not return local host in case of IP.IsUnspecified (#588) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 16, 2020
illbegood
pushed a commit
to illbegood/sdk
that referenced
this pull request
Dec 20, 2020
…ified (networkservicemesh#588) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood
pushed a commit
to illbegood/sdk
that referenced
this pull request
Dec 20, 2020
…ified (networkservicemesh#588) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingajkin denis.tingajkin@xored.com