fix: expire nse server chain element should set expiration time for endpoints #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com>
denis-tingaikin
changed the title
denis-tingaikin
requested review from
haiodo and
edwarnicke
and removed request for
haiodo
haiodo
reviewed
Dec 25, 2020
| @@ -128,10 +130,11 @@ func NewServer(ctx context.Context, nsmRegistration *registryapi.NetworkServiceE | |||
|
|
|||
| nseChain := chain_registry.NewNamedNetworkServiceEndpointRegistryServer( | |||
| nsmRegistration.Name+".NetworkServiceEndpointRegistry", | |||
| expire.NewNetworkServiceEndpointRegistryServer(time.Minute), | |||
There was a problem hiding this comment.
Did we decide to make it configurable?
haiodo
reviewed
Dec 25, 2020
| ) | ||
|
|
||
| // NewServer creates new registry server based on memory storage | ||
| func NewServer(ctx context.Context, proxyRegistryURL *url.URL, options ...grpc.DialOption) registryserver.Registry { | ||
| nseChain := chain.NewNetworkServiceEndpointRegistryServer( | ||
| setid.NewNetworkServiceEndpointRegistryServer(), | ||
| expire.NewNetworkServiceEndpointRegistryServer(), | ||
| expire.NewNetworkServiceEndpointRegistryServer(time.Minute), |
There was a problem hiding this comment.
I think we should configure it.
haiodo
approved these changes
Dec 25, 2020
|
Let's move configuration to next PR. |
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Dec 28, 2020
…k@master networkservicemesh/sdk#630 networkservicemesh/sdk PR link: networkservicemesh/sdk#630 networkservicemesh/sdk commit message: commit 4e3006826a6af8038943fcc23936cd0ebc261a50 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Dec 28 14:12:12 2020 +0700 rework expire nse server chain element (#630) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Dec 28, 2020
…k@master networkservicemesh/sdk#630 networkservicemesh/sdk PR link: networkservicemesh/sdk#630 networkservicemesh/sdk commit message: commit 4e3006826a6af8038943fcc23936cd0ebc261a50 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Dec 28 14:12:12 2020 +0700 rework expire nse server chain element (#630) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Dec 28, 2020
…k@master networkservicemesh/sdk#630 networkservicemesh/sdk PR link: networkservicemesh/sdk#630 networkservicemesh/sdk commit message: commit 4e3006826a6af8038943fcc23936cd0ebc261a50 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Dec 28 14:12:12 2020 +0700 rework expire nse server chain element (#630) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Dec 28, 2020
…k@master networkservicemesh/sdk#630 networkservicemesh/sdk PR link: networkservicemesh/sdk#630 networkservicemesh/sdk commit message: commit 4e3006826a6af8038943fcc23936cd0ebc261a50 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Dec 28 14:12:12 2020 +0700 rework expire nse server chain element (#630) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Dec 28, 2020
…k@master networkservicemesh/sdk#630 networkservicemesh/sdk PR link: networkservicemesh/sdk#630 networkservicemesh/sdk commit message: commit 4e3006826a6af8038943fcc23936cd0ebc261a50 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Dec 28 14:12:12 2020 +0700 rework expire nse server chain element (#630) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Dec 28, 2020
…k@master networkservicemesh/sdk#630 networkservicemesh/sdk PR link: networkservicemesh/sdk#630 networkservicemesh/sdk commit message: commit 4e3006826a6af8038943fcc23936cd0ebc261a50 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Mon Dec 28 14:12:12 2020 +0700 rework expire nse server chain element (#630) Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingajkin denis.tingajkin@xored.com
Closes #508, #623
Motivation
We should not allow endpoints and forwarders to set any expiration time on registration.
expireserver should set some default expiration time for the NSE / cross-NSE.