Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework nsmlabels to nsurl. #693

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Rework nsmlabels to nsurl. #693

merged 1 commit into from
Feb 2, 2021

Conversation

edwarnicke
Copy link
Member

No description provided.

denis-tingaikin
denis-tingaikin approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea

denis-tingaikin
denis-tingaikin reviewed Feb 2, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
denis-tingaikin
denis-tingaikin reviewed Feb 2, 2021
View reviewed changes
pkg/tools/nsurl/nsurl.go Outdated
)

// NSURL - wrapper around *url.URL to allow easy extraction of NSM related information
type NSURL struct {
Copy link
Member

@denis-tingaikin denis-tingaikin Feb 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we can define a type based on another type.
For example:

Suggested change
type NSURL struct {
type NSURL url.URL

In this case, we could use a typecast to covert url.URL to NSURL or vise versa.
That means L43-L47 in this case can be removed.

@edwarnicke
Rework nsmlabels to nsurl.
c83d034 
This is mostly just a reworking of the style of the approach, but it does
have a fix for handling interdomain network services

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
denis-tingaikin
denis-tingaikin approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwarnicke Nice!

@denis-tingaikin denis-tingaikin merged commit 0bf5efc into networkservicemesh:master Feb 2, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
33aafb0 
…k@master networkservicemesh/sdk#693

networkservicemesh/sdk PR link: networkservicemesh/sdk#693

networkservicemesh/sdk commit message:
commit 0bf5efc158e0365a764bc2bb6a15a4ba3ac8237a
Author: Ed Warnicke <hagbard@gmail.com>
Date:   Tue Feb 2 15:10:17 2021 -0600

    Rework nsmlabels to nsurl. (#693)

    This is mostly just a reworking of the style of the approach, but it does
    have a fix for handling interdomain network services

    Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1eb5376 
…k@master networkservicemesh/sdk#693

networkservicemesh/sdk PR link: networkservicemesh/sdk#693

networkservicemesh/sdk commit message:
commit 0bf5efc158e0365a764bc2bb6a15a4ba3ac8237a
Author: Ed Warnicke <hagbard@gmail.com>
Date:   Tue Feb 2 15:10:17 2021 -0600

    Rework nsmlabels to nsurl. (#693)

    This is mostly just a reworking of the style of the approach, but it does
    have a fix for handling interdomain network services

    Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
061a979 
…k@master networkservicemesh/sdk#693

networkservicemesh/sdk PR link: networkservicemesh/sdk#693

networkservicemesh/sdk commit message:
commit 0bf5efc158e0365a764bc2bb6a15a4ba3ac8237a
Author: Ed Warnicke <hagbard@gmail.com>
Date:   Tue Feb 2 15:10:17 2021 -0600

    Rework nsmlabels to nsurl. (#693)

    This is mostly just a reworking of the style of the approach, but it does
    have a fix for handling interdomain network services

    Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9478fd2 
…k@master networkservicemesh/sdk#693

networkservicemesh/sdk PR link: networkservicemesh/sdk#693

networkservicemesh/sdk commit message:
commit 0bf5efc158e0365a764bc2bb6a15a4ba3ac8237a
Author: Ed Warnicke <hagbard@gmail.com>
Date:   Tue Feb 2 15:10:17 2021 -0600

    Rework nsmlabels to nsurl. (#693)

    This is mostly just a reworking of the style of the approach, but it does
    have a fix for handling interdomain network services

    Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d488456 
…k@master networkservicemesh/sdk#693

networkservicemesh/sdk PR link: networkservicemesh/sdk#693

networkservicemesh/sdk commit message:
commit 0bf5efc158e0365a764bc2bb6a15a4ba3ac8237a
Author: Ed Warnicke <hagbard@gmail.com>
Date:   Tue Feb 2 15:10:17 2021 -0600

    Rework nsmlabels to nsurl. (#693)

    This is mostly just a reworking of the style of the approach, but it does
    have a fix for handling interdomain network services

    Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
07f49e0 
…k@master networkservicemesh/sdk#693

networkservicemesh/sdk PR link: networkservicemesh/sdk#693

networkservicemesh/sdk commit message:
commit 0bf5efc158e0365a764bc2bb6a15a4ba3ac8237a
Author: Ed Warnicke <hagbard@gmail.com>
Date:   Tue Feb 2 15:10:17 2021 -0600

    Rework nsmlabels to nsurl. (#693)

    This is mostly just a reworking of the style of the approach, but it does
    have a fix for handling interdomain network services

    Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f2e3378 
…k@master networkservicemesh/sdk#693

networkservicemesh/sdk PR link: networkservicemesh/sdk#693

networkservicemesh/sdk commit message:
commit 0bf5efc158e0365a764bc2bb6a15a4ba3ac8237a
Author: Ed Warnicke <hagbard@gmail.com>
Date:   Tue Feb 2 15:10:17 2021 -0600

    Rework nsmlabels to nsurl. (#693)

    This is mostly just a reworking of the style of the approach, but it does
    have a fix for handling interdomain network services

    Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
32fa343 
…k@master networkservicemesh/sdk#693

networkservicemesh/sdk PR link: networkservicemesh/sdk#693

networkservicemesh/sdk commit message:
commit 0bf5efc158e0365a764bc2bb6a15a4ba3ac8237a
Author: Ed Warnicke <hagbard@gmail.com>
Date:   Tue Feb 2 15:10:17 2021 -0600

    Rework nsmlabels to nsurl. (#693)

    This is mostly just a reworking of the style of the approach, but it does
    have a fix for handling interdomain network services

    Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Feb 2, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
35ce5fe 
…k@master networkservicemesh/sdk#693

networkservicemesh/sdk PR link: networkservicemesh/sdk#693

networkservicemesh/sdk commit message:
commit 0bf5efc158e0365a764bc2bb6a15a4ba3ac8237a
Author: Ed Warnicke <hagbard@gmail.com>
Date:   Tue Feb 2 15:10:17 2021 -0600

    Rework nsmlabels to nsurl. (#693)

    This is mostly just a reworking of the style of the approach, but it does
    have a fix for handling interdomain network services

    Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 2, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwarnicke @denis-tingaikin