Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race in connect client #800

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Fix data race in connect client #800

merged 1 commit into from
Mar 31, 2021

Conversation

Bolodya1997
Copy link

Issue

Such code results in a data race, because u.dialOptions is the same slice for all connect clients.

append(u.dialOptions, grpc.WithReturnConnectionError())

Solution

append(append([]grpc.DialOption{}, u.dialOptions...), grpc.WithReturnConnectionError())

Fix data race in connect client
e62413c 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@haiodo haiodo merged commit 964332c into networkservicemesh:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bolodya1997 @haiodo