Update go to 1.23 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
Ex4amp1e
commented
Nov 13, 2024
| @@ -10,26 +11,23 @@ linters-settings: | |||
| values: | |||
| regexp: | |||
| company: .* | |||
| copyright-holder: Copyright \(c\) ({{year-range}}) {{company}}\n\n | |||
| copyright-holder: Copyright \(c\) ({{mod-year-range}}) {{company}}\n\n | |||
There was a problem hiding this comment.
vpphelper is the only repository where this fix does not help to avoid goheader linter error for file, that has not been modified in the PR.
There was a problem hiding this comment.
@denis-tingaikin any ideas to fix golangci-lint error?
Error: Pattern (Copyright \(c\) (((20\d\d\-2023)|(2023))) .*\n\n)+ doesn't match. (goheader)
I can get it locally too in connection.go file
|
@Ex4amp1e Any updates? |
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
There was a problem hiding this comment.
Could you use golangci config as a base from https://github.com/networkservicemesh/api/blob/main/.golangci.yml ?
|
@Ex4amp1e Any news? |
Signed-off-by: Vladislav Byrgazov <vladislav.byrgazov@xored.com>
Done |
denis-tingaikin
approved these changes
Nov 19, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Nov 19, 2024
…phelper@main PR link: networkservicemesh/vpphelper#7 Commit: 171e747 Author: Denis Tingaikin Date: 2024-11-19 05:14:02 -0500 Message: - Merge pull request #7 from Ex4amp1e/update-go-1.23 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-simple-docker
that referenced
this pull request
Nov 19, 2024
…phelper@main PR link: networkservicemesh/vpphelper#7 Commit: 171e747 Author: Denis Tingaikin Date: 2024-11-19 05:14:02 -0500 Message: - Merge pull request #7 from Ex4amp1e/update-go-1.23 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Nov 19, 2024
…phelper@main PR link: networkservicemesh/vpphelper#7 Commit: 171e747 Author: Denis Tingaikin Date: 2024-11-19 05:14:02 -0500 Message: - Merge pull request #7 from Ex4amp1e/update-go-1.23 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Nov 19, 2024
…phelper@main PR link: networkservicemesh/vpphelper#7 Commit: 171e747 Author: Denis Tingaikin Date: 2024-11-19 05:14:02 -0500 Message: - Merge pull request #7 from Ex4amp1e/update-go-1.23 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Nov 19, 2024
…phelper@main PR link: networkservicemesh/vpphelper#7 Commit: 171e747 Author: Denis Tingaikin Date: 2024-11-19 05:14:02 -0500 Message: - Merge pull request #7 from Ex4amp1e/update-go-1.23 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-simple-vl3-docker
that referenced
this pull request
Nov 19, 2024
…phelper@main PR link: networkservicemesh/vpphelper#7 Commit: 171e747 Author: Denis Tingaikin Date: 2024-11-19 05:14:02 -0500 Message: - Merge pull request #7 from Ex4amp1e/update-go-1.23 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Nov 19, 2024
…phelper@main PR link: networkservicemesh/vpphelper#7 Commit: 171e747 Author: Denis Tingaikin Date: 2024-11-19 05:14:02 -0500 Message: - Merge pull request #7 from Ex4amp1e/update-go-1.23 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Nov 19, 2024
…phelper@main PR link: networkservicemesh/vpphelper#7 Commit: 171e747 Author: Denis Tingaikin Date: 2024-11-19 05:14:02 -0500 Message: - Merge pull request #7 from Ex4amp1e/update-go-1.23 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 19, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: networkservicemesh/deployments-k8s#12294