Fix ITE Cache to be more Rust-like #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
IteTable
. Not all the implements are Lru (so I'm not sure if that made sense), andIte
is bound to the typeBddApplyTable
is now called theLruIteTable
, since the previous name didn't indicate that it was Lru or operated onIte
AllTable
is not calledAllIteTable
for consistencybuilder::cache
hierarchy, so now it isbuilder::cache::IteTable
, etc. (instead ofbuilder::cache::ite_table::IteTable
)new_default_order
tonew_with_linear_order
to be more clearRobddBuilder
, since they can imply a different type than the actual parametrized type (ex, anRobddBuilder
overAllIteTable
could return anRobddBuilder
overLruIteTable
, which doesn't make sense)IteTable
for theRobddBuilder
using theDefault
trait instead of having it in the constructor, since that's what we do in all callsites anywaysI would have loved to then alias the
IteTable
s over aBddPtr
as some sort ofBddIteTable
, but unfortunately, trait aliases are unstable.