Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ITE Cache to be more Rust-like #153

Merged
merged 6 commits into from
Jul 22, 2023

Conversation

mattxwang
Copy link
Member

@mattxwang mattxwang commented Jul 21, 2023

This PR:

  • renames things to be more consistent:
    • the table trait is now called IteTable. Not all the implements are Lru (so I'm not sure if that made sense), and Ite is bound to the type
    • the BddApplyTable is now called the LruIteTable, since the previous name didn't indicate that it was Lru or operated on Ite
    • the AllTable is not called AllIteTable for consistency
  • flattens the builder::cache hierarchy, so now it is builder::cache::IteTable, etc. (instead of builder::cache::ite_table::IteTable)
  • renames new_default_order to new_with_linear_order to be more clear
  • removes the concrete type constructors for RobddBuilder, since they can imply a different type than the actual parametrized type (ex, an RobddBuilder over AllIteTable could return an RobddBuilder over LruIteTable, which doesn't make sense)
  • automatically instantiates the IteTable for the RobddBuilder using the Default trait instead of having it in the constructor, since that's what we do in all callsites anyways

I would have loved to then alias the IteTables over a BddPtr as some sort of BddIteTable, but unfortunately, trait aliases are unstable.

@mattxwang mattxwang force-pushed the tidy-up-robdd-builder-construction branch from cee6624 to 1704b26 Compare July 22, 2023 19:38
@mattxwang mattxwang marked this pull request as ready for review July 22, 2023 19:43
@mattxwang mattxwang changed the title Standardize ITE Cache Fix ITE Cache to be more Rust-like Jul 22, 2023
@mattxwang mattxwang merged commit c590743 into main Jul 22, 2023
7 checks passed
@mattxwang mattxwang deleted the tidy-up-robdd-builder-construction branch July 22, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant