Semantic BDD Pointers! #163
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocker: need access to builder for some operations (namely, deref). Doesn't build rn :(
This doesn't compile; need to pause since some `BddPtr` logic lives in `VarOrder`, and it probably shouldn't.
mattxwang
added a commit
that referenced
this pull request
Jul 27, 2023
…trait, fixes ref/lifetimes Two problems: 1. `VarOrder`'s `first`, `first_essential`, and `sort` methods rely on the input type being a `BddPtr`, which causes problems for #163. So, I've instead abstracted the idea of a partial variable order, i.e. that structs may or may not have a sortable variable, to a trait; `BddPtr` (and soon, `SemanticBddPtr`) implements this trait. This caused minimal code impact. 2. `first`, `first_essential`, and `sort` shouldn't consume their inputs, so I've changed these to just be refs. Required lifetime annotations. Then, added doctests for these methods!
mattxwang
added a commit
that referenced
this pull request
Jul 27, 2023
…164) Two problems: 1. `VarOrder`'s `first`, `first_essential`, and `sort` methods rely on the input type being a `BddPtr`, which causes problems for #163. So, I've instead abstracted the idea of a partial variable order, i.e. that structs may or may not have a sortable variable, to a trait; `BddPtr` (and soon, `SemanticBddPtr`) implements this trait. This caused minimal code impact. 2. `first`, `first_essential`, and `sort` shouldn't consume their inputs, so I've changed these to just be refs. Required lifetime annotations. Then, added doctests for these methods!
bypassing issues with lifetimes and ownership
This still doesn't work; next attempt will see if we can perhaps make each pointer only own the hash?
This was referenced Aug 3, 2023
mattxwang
added a commit
that referenced
this pull request
Aug 3, 2023
Note to self: before merging this, we should do a bit more benchmarking to see how this actually affects perf. From #163, it seems negligble.
mattxwang
added a commit
that referenced
this pull request
Aug 3, 2023
Cherry-picking this change over from #163, to make it easier to review (and to revert this if necessary).
mattxwang
added a commit
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heavily in draft; need to cherry pick some of these changes
interesting results