Place C bindings behind ffi feature flag, add FFI CI
#178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattxwang
force-pushed
the
ffi-feature-flag
branch
4 times, most recently
from
8a05cdc
to
2981c7e
Compare
|
Annoyed at CI not working, since I can't repro this locally :/ makes me feel like I'm not using the CI env properly? |
mattxwang
changed the title
ffi feature flag, add CIffi feature flag, add FFI CI
mattxwang
force-pushed
the
ffi-feature-flag
branch
2 times, most recently
from
eafaf65
to
74adb13
Compare
mattxwang
force-pushed
the
ffi-feature-flag
branch
from
74adb13
to
790af1b
Compare
|
Wow... it was that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially codifies #171 into some CI; this is necessary so that we don't have duplicate symbols with rsdd-ocaml.
(the instructions for #171 still work, except you now need to build with the feature flag, i.e.
cargo build --features="ffi")