Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Rust CI, fixes string interpolation in panic! #1

Closed
wants to merge 3 commits into from
Closed

Adds Rust CI, fixes string interpolation in panic! #1

wants to merge 3 commits into from

Conversation

mattxwang
Copy link
Member

@mattxwang mattxwang commented Jul 24, 2022

I noticed that I couldn't build rsdd from scratch anymore. This PR should resolve those problems! It:

  1. Fixes some issues with string interpolation (moving "{variable}" -> "{}", variable in panic!())
  2. Adds a CI check to (hopefully) catch these errors in the future

@mattxwang
Copy link
Member Author

Oops - I think this is instead me missing format string capturing in Rust 2022. I'll close this and add some other changes to clarify this later!

@mattxwang mattxwang closed this Jul 25, 2022
@mattxwang mattxwang deleted the mwang/fix-string-interpolation-gh-actions branch July 25, 2022 04:21
@mattxwang mattxwang restored the mwang/fix-string-interpolation-gh-actions branch July 25, 2022 04:21
@mattxwang mattxwang deleted the mwang/fix-string-interpolation-gh-actions branch July 25, 2022 04:21
@SHoltzen
Copy link
Collaborator

Got it, makes sense.

Let's add some CI though to this project -- always good to have. If you still have that code let's merge it.

@mattxwang
Copy link
Member Author

Can do - I can make a PR once I'm back from work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants